Mochitest RTCP timestamp checks are too tight for two machine scenarios

RESOLVED FIXED in Firefox 35

Status

()

Core
WebRTC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: drno, Assigned: drno)

Tracking

Trunk
mozilla36
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We experience lots of test failures around the RTCP time stamp verification if we execute our tests via steeplechase on two different machines.
Probably the reason is that the clocks of the virtual machines used for the steeplechase tests are not as well synchronized as you would expect on a single machine. We should relax the time stamp check in case of steeplechase.
(Assignee)

Comment 1

3 years ago
Created attachment 8504394 [details] [diff] [review]
bug_1082236_fix_rtcp_timestamp_verification.patch

Give 10s more time for comparing RTCP time stamps in case tests run via steeplechase.
Attachment #8504394 - Flags: review?(spolk)
(Assignee)

Comment 2

3 years ago
Try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=bbea6474cd17

Comment 3

3 years ago
Comment on attachment 8504394 [details] [diff] [review]
bug_1082236_fix_rtcp_timestamp_verification.patch

Review of attachment 8504394 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Be sure to request uplift to Aurora.
Attachment #8504394 - Flags: review?(spolk) → review+
(Assignee)

Comment 4

3 years ago
Try run looks green.
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/631716528bf8
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/631716528bf8
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
(Assignee)

Comment 7

3 years ago
Comment on attachment 8504394 [details] [diff] [review]
bug_1082236_fix_rtcp_timestamp_verification.patch

Approval Request Comment
[Feature/regressing bug #]: The current tests require a very precise clock, which works on TBPL but not very well in our new multi machine WebRTC test setup.
[User impact if declined]: The test runs in our new multi machine WebRTC test setup (steeplechase) throw intermittent test failures.
[Describe test coverage new/current, TBPL]: This only relaxes one existing test condition if the test gets executed on steeplechase.
[Risks and why]: Minimal as relaxed time stamp checking is not active on TBPL.
[String/UUID change made/needed]: n/a
Attachment #8504394 - Flags: approval-mozilla-aurora?
status-firefox35: --- → affected
status-firefox36: --- → fixed
Attachment #8504394 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/8949cb909baf
status-firefox35: affected → fixed

Updated

3 years ago
Summary: Mochitest RTCP timestamp checks are to tight for two machine scenarios → Mochitest RTCP timestamp checks are too tight for two machine scenarios
You need to log in before you can comment on or make changes to this bug.