Closed Bug 1082236 Opened 5 years ago Closed 5 years ago

Mochitest RTCP timestamp checks are too tight for two machine scenarios

Categories

(Core :: WebRTC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: drno, Assigned: drno)

Details

Attachments

(1 file)

We experience lots of test failures around the RTCP time stamp verification if we execute our tests via steeplechase on two different machines.
Probably the reason is that the clocks of the virtual machines used for the steeplechase tests are not as well synchronized as you would expect on a single machine. We should relax the time stamp check in case of steeplechase.
Give 10s more time for comparing RTCP time stamps in case tests run via steeplechase.
Attachment #8504394 - Flags: review?(spolk)
Comment on attachment 8504394 [details] [diff] [review]
bug_1082236_fix_rtcp_timestamp_verification.patch

Review of attachment 8504394 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Be sure to request uplift to Aurora.
Attachment #8504394 - Flags: review?(spolk) → review+
Try run looks green.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/631716528bf8
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment on attachment 8504394 [details] [diff] [review]
bug_1082236_fix_rtcp_timestamp_verification.patch

Approval Request Comment
[Feature/regressing bug #]: The current tests require a very precise clock, which works on TBPL but not very well in our new multi machine WebRTC test setup.
[User impact if declined]: The test runs in our new multi machine WebRTC test setup (steeplechase) throw intermittent test failures.
[Describe test coverage new/current, TBPL]: This only relaxes one existing test condition if the test gets executed on steeplechase.
[Risks and why]: Minimal as relaxed time stamp checking is not active on TBPL.
[String/UUID change made/needed]: n/a
Attachment #8504394 - Flags: approval-mozilla-aurora?
Attachment #8504394 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Summary: Mochitest RTCP timestamp checks are to tight for two machine scenarios → Mochitest RTCP timestamp checks are too tight for two machine scenarios
You need to log in before you can comment on or make changes to this bug.