Closed
Bug 1082236
Opened 10 years ago
Closed 10 years ago
Mochitest RTCP timestamp checks are too tight for two machine scenarios
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: drno, Assigned: drno)
Details
Attachments
(1 file)
2.87 KB,
patch
|
sydpolk
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We experience lots of test failures around the RTCP time stamp verification if we execute our tests via steeplechase on two different machines. Probably the reason is that the clocks of the virtual machines used for the steeplechase tests are not as well synchronized as you would expect on a single machine. We should relax the time stamp check in case of steeplechase.
Assignee | ||
Comment 1•10 years ago
|
||
Give 10s more time for comparing RTCP time stamps in case tests run via steeplechase.
Attachment #8504394 -
Flags: review?(spolk)
Assignee | ||
Comment 2•10 years ago
|
||
Try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=bbea6474cd17
Comment 3•10 years ago
|
||
Comment on attachment 8504394 [details] [diff] [review] bug_1082236_fix_rtcp_timestamp_verification.patch Review of attachment 8504394 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Be sure to request uplift to Aurora.
Attachment #8504394 -
Flags: review?(spolk) → review+
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/631716528bf8
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/631716528bf8
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8504394 [details] [diff] [review] bug_1082236_fix_rtcp_timestamp_verification.patch Approval Request Comment [Feature/regressing bug #]: The current tests require a very precise clock, which works on TBPL but not very well in our new multi machine WebRTC test setup. [User impact if declined]: The test runs in our new multi machine WebRTC test setup (steeplechase) throw intermittent test failures. [Describe test coverage new/current, TBPL]: This only relaxes one existing test condition if the test gets executed on steeplechase. [Risks and why]: Minimal as relaxed time stamp checking is not active on TBPL. [String/UUID change made/needed]: n/a
Attachment #8504394 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
status-firefox35:
--- → affected
status-firefox36:
--- → fixed
Updated•10 years ago
|
Attachment #8504394 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•10 years ago
|
Summary: Mochitest RTCP timestamp checks are to tight for two machine scenarios → Mochitest RTCP timestamp checks are too tight for two machine scenarios
You need to log in
before you can comment on or make changes to this bug.
Description
•