1082289 - Put Commonplace dependency in `package.json`

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

Maybe this bug is already solved by bug 1072684, so feel free to dupe if so.

We should stop hardcoding specific commonplace versions in our `fabfile.py`:

    https://github.com/mozilla/fireplace/blob/c9f5668/fabfile.py#L38

and then having developers (and Fabric) install Commonplace globally.

It's caused a bunch of confusion. And the current workaround is this:

    https://github.com/mozilla/fireplace/commit/c9f5668

npm makes this very easy. So let's just add `commonplace` (pinned to a version) to the `dependencies` section in our `package.json`. That way when the user installs Fireplace (`npm install`), Commonplace will be installed (and the correct version that the project requires) in the project's `node_modules/` directory.

I realise it's convenient to be able to call just `commonplace includes`, etc. from the command line. Instead we forgo `damper`/`commonplace` commands in favour of `gulp` (or `npm`) commands.

Comment 1

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/blob/master/package.json#L16

Commonplace no longer has much of a CLI anyways. We expose our CLI stuff through the Makefile.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/blob/master/package.json#L16

Why is `commonplace` not pinned to a version though? Shouldn't it match the version that we specify in the `fabfile.py`/`README.md`?

Comment 3

[Kevin Ngo [:ngoke]]

There is no version specified in the fabfile or the README. They both just run npm install.