Closed
Bug 1082329
Opened 10 years ago
Closed 10 years ago
Remove unused tests in the tests/ directory
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
2.1 S7 (24Oct)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
These files appear to be old and can be confusing to our contributors. If they are not in use - we should remove them. I also don't think they will provide us much value to keep around as they are outdated, and most have not been updated in 2-3 years. Just looking for a few reviews from people who have contributed to these files in the past. Thanks!
Attachment #8504484 -
Flags: review?(jlal)
Attachment #8504484 -
Flags: review?(etienne)
Attachment #8504484 -
Flags: review?(dflanagan)
Comment 2•10 years ago
|
||
Comment on attachment 8504484 [details] [review] Github pull request /me sheds a tear of nostalgia :')
Attachment #8504484 -
Flags: review?(etienne) → review+
Comment 3•10 years ago
|
||
Kevin, Could you also remove the respective file paths from the .jshintignore file, so that way there are only a few files in the tests/ directory for which the hint test has to work. I would love to push the changes to .jshintignore if you merge this and want me to do it, or else you could do the changes too.
Flags: needinfo?(kgrandon)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8504484 [details] [review] Github pull request I'm pretty confident in this and don't want to waste peoples time reviewing, so going to land with Etiennes review. Thanks guys!
Attachment #8504484 -
Flags: review?(jlal)
Attachment #8504484 -
Flags: review?(dflanagan)
Flags: needinfo?(kgrandon)
Assignee | ||
Comment 5•10 years ago
|
||
In master: https://github.com/mozilla-b2g/gaia/commit/8533afdb638da4abc2b2b95e917c53d415f1f0c2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S7 (24Oct)
Assignee | ||
Comment 6•10 years ago
|
||
Argh, forgot to push the commit to remove the files from jshintignore. Here it is.
Assignee | ||
Comment 7•10 years ago
|
||
Landed follow-up: https://github.com/mozilla-b2g/gaia/commit/ff35b78625be1e3e4117be6731b43f8baabc912b Files should now be removed from jshintignore.
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•