charsetOverlay.js treats "intl.charset.detector" pref incorrectly

VERIFIED FIXED in mozilla0.9.7

Status

()

VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: bnesse, Assigned: bnesse)

Tracking

Trunk
mozilla0.9.7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

17 years ago
This may, or may not, have some impact on some of the currently open charset
detector bugs.

While converting the JS files from the nsIPref to the
nsIPrefService/nsIPrefBranch interfaces, I noticed that the preference
"intl.charset.detector" was being read in as a LocalizedUnicharPref and written
out as a CharPref. This is wrong. A preference read in as LocalizedUnicharPref
should be written out as a Unichar preference.
(Assignee)

Comment 1

17 years ago
Created attachment 56280 [details] [diff] [review]
Proposed patch
(Assignee)

Comment 2

17 years ago
The proposed patch fixes the read/write issues, removes some tabs and makes all
of the whitespace consistent.
(Assignee)

Comment 3

17 years ago
Sorry, forgot to mention... This patch is not fully tested due to being blocked
by bug 107786 (no menus).

Updated

17 years ago
Blocks: 106749
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.6

Comment 4

17 years ago
bnesse: On the other hand, I think you should own this bug.
I'll test your patch.
->bnesse
Assignee: yokoyama → bnesse
Status: ASSIGNED → NEW
(Assignee)

Comment 5

17 years ago
I have tested this as far as I can. The functions which set the preference are
apparently never called, probably due to the wrong attribute name being returned
from the event (bug 106749). Clearing blocker status as this is not blocking 106749.
No longer blocks: 106749
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9.6 → mozilla0.9.7
(Assignee)

Comment 6

17 years ago
Setting 106749 as blocking this bug. I think this is what Roy really meant to do
in the first place.
Depends on: 106749
(Assignee)

Comment 7

17 years ago
Created attachment 57518 [details] [diff] [review]
Patch updated for charsetOverlay.js changes.

I've updated the patch because recent changes to charsetOverlay.js cause merge
conflicts with the old one. With waterson's checkin for bug 106749 in on the
trunk I have now successfully tested the patch.
Attachment #56280 - Attachment is obsolete: true

Comment 8

17 years ago
Comment on attachment 57518 [details] [diff] [review]
Patch updated for charsetOverlay.js changes.

/r=yokoyama
Thanks, Brian
Attachment #57518 - Flags: review+

Comment 9

17 years ago
Comment on attachment 57518 [details] [diff] [review]
Patch updated for charsetOverlay.js changes.

sr=alecf
Attachment #57518 - Flags: superreview+
(Assignee)

Comment 10

17 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 11

17 years ago
Verified from Roy's comment.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.