1082399 - [Text Selection] Tapping the touch caret should show Paste utility bubble if clipboard is not empty - gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

Follow-up of bug 1067231.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Morris,
I would like to have your feedback for touchcarettap part.
Thanks.

PS: we will also need to fix scrolling issue on another bug.

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8504501 [details] [review]
PR to master

Looks good. Thanks!

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8504501 [details] [review]
PR to master

Hi Alive,
could you take a look of my patch? Thanks.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8504501 [details] [review]
PR to master

See github comments

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8504501 [details] [review]
PR to master

Thanks Alive, I've updated. Please kindly check again, thanks!

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8504501 [details] [review]
PR to master

All is test issues, please request review again once fixed, thanks.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8504501 [details] [review]
PR to master

Thanks, test has been updated!

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8504501 [details] [review]
PR to master

r=me, thanks!

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks , master: https://github.com/mozilla-b2g/gaia/commit/3a51b56f0dfaaa00f061a28dc8440d8b30ed3db2