Closed Bug 1082399 Opened 6 years ago Closed 6 years ago

[Text Selection] Tapping the touch caret should show Paste utility bubble if clipboard is not empty - gaia

Categories

(Firefox OS Graveyard :: Gaia::System, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gduan, Assigned: gduan)

References

Details

Attachments

(1 file)

Assignee: nobody → gduan
Attached file PR to master
Hi Morris,
I would like to have your feedback for touchcarettap part.
Thanks.

PS: we will also need to fix scrolling issue on another bug.
Attachment #8504501 - Flags: feedback?(mtseng)
Comment on attachment 8504501 [details] [review]
PR to master

Looks good. Thanks!
Attachment #8504501 - Flags: feedback?(mtseng) → feedback+
Comment on attachment 8504501 [details] [review]
PR to master

Hi Alive,
could you take a look of my patch? Thanks.
Attachment #8504501 - Flags: review?(alive)
Comment on attachment 8504501 [details] [review]
PR to master

See github comments
Attachment #8504501 - Flags: review?(alive)
Comment on attachment 8504501 [details] [review]
PR to master

Thanks Alive, I've updated. Please kindly check again, thanks!
Attachment #8504501 - Flags: review?(alive)
Priority: -- → P2
Comment on attachment 8504501 [details] [review]
PR to master

All is test issues, please request review again once fixed, thanks.
Attachment #8504501 - Flags: review?(alive)
Comment on attachment 8504501 [details] [review]
PR to master

Thanks, test has been updated!
Attachment #8504501 - Flags: review?(alive)
Comment on attachment 8504501 [details] [review]
PR to master

r=me, thanks!
Attachment #8504501 - Flags: review?(alive) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.