Closed Bug 1082477 Opened 10 years ago Closed 10 years ago

Convert Matrix4x4::TranslatePost/ScalePost callers to Matrix4x4::PostTranslate/PostScale

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(2 files)

When I added the PostTranslate and PostScale methods to Matrix4x4 in the first patch for bug 1077961 I didn't notice that there were already methods with the same functionality but with the "Post" appended to the name instead of prepended as they are for the Matrix class. (Since methods of related names are not grouped.) We should get rid of the previous functions and convert the existing callers to the new method names.
Attachment #8504585 - Flags: review?(bas) → review+
Attachment #8504586 - Flags: review?(bas) → review+
Comment on attachment 8504585 [details] [diff] [review]
part 1 - Convert Matrix4x4::TranslatePost/ScalePost callers to Matrix4x4::PostTranslate/PostScale

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1236b26c43f
Attachment #8504585 - Flags: checkin+
Comment on attachment 8504586 [details] [diff] [review]
part 2 - Remove the Matrix4x4::TranslatePost/ScalePost methods

https://hg.mozilla.org/integration/mozilla-inbound/rev/4de60ee2e647
Attachment #8504586 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/e1236b26c43f
https://hg.mozilla.org/mozilla-central/rev/4de60ee2e647
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.