Closed Bug 1082507 Opened 10 years ago Closed 10 years ago

Load wizard code only when it is needed in order to consume less memory and load faster the app

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [mobile app][Loop not in v1.1])

Attachments

(1 file)

We have to load the markup and libraries when they are needed (first run, logout, etc...) This code is needed few times by users
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Whiteboard: [mobile app]
Attached file Github pull request
Just when you have a chance to take a look at here, gracias Borja
Attachment #8504648 - Flags: feedback?(borja.bugzilla)
Blocks: 1088519
Depends on: 1088521
Comment on attachment 8504648 [details]
Github pull request

Thanks a lot
Attachment #8504648 - Flags: feedback?(borja.bugzilla) → review?(ferjmoreno)
No longer depends on: 1088521
Comment on attachment 8504648 [details]
Github pull request

Sorry, Cristian, I couldn't take a look at this today and it seems that this patch deserves some good testing time.
Jaoo, can you take a look, please?
Attachment #8504648 - Flags: review?(ferjmoreno) → review?(josea.olivera)
Comment on attachment 8504648 [details]
Github pull request

LGTM. r=me

I left a tiny comment on the PR. Have a look at it and land at will. Thanks!
Attachment #8504648 - Flags: review?(josea.olivera) → review+
Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/953039b2d9e5ee1fa2ac0ccb96eb9a5c49d2e5b2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 1090161
No longer blocks: 1090161
Whiteboard: [mobile app] → [mobile app][Loop not in v1.1]
Tested. Once Loop application is loaded, user can see tutorial at the begining
Flame
user
v2.0
Gecko-05f9775
Gaia-d3e4da3
Loop version: master , dd4862e
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: