1082521 - [Status bar] Icons color is wrong on context menus

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

STR:

1.- Search with the rocketbar
2.- Click on a result
3.- Click on the context menu icon ('...')

Expected

Icons are white

Actual

Icons are dark

Comment 1

[Alberto Pastor [:albertopq]]

[Blocking Requested - why for this release]: Broken UI. Just tried, and is repro in 2.1

Comment 2

[Alberto Pastor [:albertopq]]

Attachment: Screenshot

Comment 3

[Alberto Pastor [:albertopq]]

Double checking with eric, as it seems it has been always like that.

Comment 4

[Candice Serran (:cserran)]

Not blocking as this currently exists in previous releases. Will put as priority backlog feature

Comment 5

[Eric Pang [:epang] UX]

clearing need info since it came up during the sync :)

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] jedireza:status-bar-icon-colors > mozilla-b2g:master

Comment 7

[Reza Akhavan [:jedireza]]

Comment on attachment 8670050 [details] [review]
[gaia] jedireza:status-bar-icon-colors > mozilla-b2g:master

Hi Alberto, if you're not the right person to ping, let me know.

I found a semi-decent way of toggling the statusbar icon colors for the context menu while in the browser. Please see the PR.

While I was fiddling with this I noticed another issue with statusbar icon colors... For example in an app that has a light colored theme, that is in the foreground, and we kill it from the activity manager, the home screen will have dark icons until we scroll up/down, which will cause the statusbar to update.

You can test this out using the Settings app.

 - Open settings
 - Hold home button to pull up activity manager
 - Kill settings
 - See home screen icons are not white

I've also noticed in the browser that if you pull up the context menu right away on first load it may revert the icon colors back to the dark versions. There is some kind of race condition there.

Thanks for taking a look.

Comment 8

[Alberto Pastor [:albertopq]]

Mhm, is this bug 1 year old? I think this might be a regression. Let's see what caused it first.

Comment 9

[John Thomas [:Johnt]]

I am seeing that this issue DOES occur on the Aries 2.5, Flame 2.5 and 2.2.
Result: Icons are dark after selecting the context menu icon ('...')

Environmental Variables:
Device: Aries 2.5 Kk
BuildID: 20151006110922
Gaia: 60cdaa3d3424db3432dc903e7f9c6c8fa099c06d
Gecko: 89732fcdb0baca70e8b7a25a2725117113f0db80
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Device: Flame 2.5 Kk Fullflash (512mb)
Build ID: 20151006030203
Gaia: 60cdaa3d3424db3432dc903e7f9c6c8fa099c06d
Gecko: 3edc8d4a1e198314f5d7ebd2967b85842beef602
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Environmental Variables:
Device: Flame 2.2 Kk (319mb)
Build ID: 20151006032504
Gaia: 5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583
Gecko: fc588eb28eab
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

I am beginning the window as of now.

Comment 10

[Marcus Cavanaugh [:mcav]]

As another data point, in line with Reza's Comment 7, it appears that there are often races causing the statusbar color to not update properly; it's not context-menu-specific, although it's possible that's also a problem. Bug 1210453, which I plan to work on at some point, may be related.

Comment 11

[John Thomas [:Johnt]]

This issue is not a regression.

The issue occurs on the first implementation of the icons found in build 20140911152320. Prior to that these icons did not appear when selecting the "..." button.

Environmental Variables:
Device: Flame 2.2 Kk
BuildID: 20140911152320
Gaia: 6cb5e0100d70313e4922c8d34bf20dcdd66ef616
Gecko: 0be3ea11a4c7
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 35.0a1 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Comment 12

[Alberto Pastor [:albertopq]]

Sorry, bug 1210453 is the one I meant to be a regression. Icons in context menus were always in that way, as you mentioned.

Comment 13

[BMO Automation]

Firefox OS is not being worked on