Closed Bug 1082527 Opened 10 years ago Closed 5 months ago

Use LibHandle's mappable field in CustomElf

Categories

(Core :: mozglue, defect)

All
Android
defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

      No description provided.
Bug 802240 added an API to get a mappable for SystemElf objects, but for some
reason this wasn't consolidated with the existing mappable field in CustomElf.
Attachment #8504673 - Flags: review?(nfroyd)
Blocks: 1082529
Comment on attachment 8504673 [details] [diff] [review]
Use LibHandle's mappable field in CustomElf

Review of attachment 8504673 [details] [diff] [review]:
-----------------------------------------------------------------

WFM
Attachment #8504673 - Flags: review?(nfroyd) → review+
Somehow, this breaks TestANRReporter (more than it already is according to the pile of bugs treeherder suggests).
Depends on: 1083014
(In reply to Mike Hommey [:glandium] from comment #1)
> Created attachment 8504673 [details] [diff] [review]
> Use LibHandle's mappable field in CustomElf
> 
> Bug 802240 added an API to get a mappable for SystemElf objects, but for some
> reason this wasn't consolidated with the existing mappable field in
> CustomElf.

And the reason for this is bug 1083014.

Can't land this until that's fixed. Considering it's more work than I'm ready to put right now, I'll find a workaround.
Severity: normal → S3

While we might be able to rebase this and get some tiny cleanup, at this point I think we can remove the entire Mappable thing, so if we're going to do anything to this code, I'd rather it be that.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: