1082527 - Use LibHandle's mappable field in CustomElf

Status: RESOLVED WONTFIX

(Core :: mozglue, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Use LibHandle's mappable field in CustomElf

Bug 802240 added an API to get a mappable for SystemElf objects, but for some
reason this wasn't consolidated with the existing mappable field in CustomElf.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8504673 [details] [diff] [review]
Use LibHandle's mappable field in CustomElf

Review of attachment 8504673 [details] [diff] [review]:
-----------------------------------------------------------------

WFM

Comment 3

[Mike Hommey [:glandium]]

Somehow, this breaks TestANRReporter (more than it already is according to the pile of bugs treeherder suggests).

Comment 4

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #1)
> Created attachment 8504673 [details] [diff] [review]
> Use LibHandle's mappable field in CustomElf
> 
> Bug 802240 added an API to get a mappable for SystemElf objects, but for some
> reason this wasn't consolidated with the existing mappable field in
> CustomElf.

And the reason for this is bug 1083014.

Can't land this until that's fixed. Considering it's more work than I'm ready to put right now, I'll find a workaround.

Comment 5

[Mike Hommey [:glandium]]

While we might be able to rebase this and get some tiny cleanup, at this point I think we can remove the entire Mappable thing, so if we're going to do anything to this code, I'd rather it be that.