1082530 - Make Moz2D's UserToDevicePixelSnapped honor disabling of pixel snapping and scale ignoring as gfxContext::UserToDevicePixelSnapped does

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

See bug 989858 comment 25 - comment 27.

Bug 989858 part 6 replaced a call to gfxContext::UserToDevicePixelSnapped() with a call to the new Moz2D helper of the same name. These functions aren't equivalent though since the Moz2D version doesn't (isn't able to) check for the presence of the FLAG_DISABLE_SNAPPING flag. The Moz2D variant also doesn't have an ignoreScale argument, so the converted caller has changed in that regard too.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: part 1 - Mark DrawTarget::GetUserData as const

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: part 2 - Fix up Moz2D's UserToDevicePixelSnapped to be more like gfxContext::UserToDevicePixelSnapped, and add a temporary variant to aid in porting

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: part 3 - Get rid of gfxContext::FLAG_DISABLE_SNAPPING and use DrawTarget UserData to store information on whether to disable pixel snapping

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: part 4 - Make BasicColorLayer use the variant of Moz2D's UserToDevicePixelSnapped that honors disabling of pixel snapping and make it ignore scaling in the matrix (restore the pre-bug 989858 beharior)

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: part 5 - remove the variant of Moz2D's UserToDevicePixelSnapped that takes a Matrix argument instead of a DrawTarget argument

Comment 6

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a45f83eeda1
https://hg.mozilla.org/integration/mozilla-inbound/rev/61c3d66c10a1
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce005765cf43
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f6dc495c8b6
https://hg.mozilla.org/integration/mozilla-inbound/rev/1abfecf86c50

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9a45f83eeda1
https://hg.mozilla.org/mozilla-central/rev/61c3d66c10a1
https://hg.mozilla.org/mozilla-central/rev/ce005765cf43
https://hg.mozilla.org/mozilla-central/rev/5f6dc495c8b6
https://hg.mozilla.org/mozilla-central/rev/1abfecf86c50