1082543 - SMS data in makeReferenceWorkload is causing Gaia/indexedDB to die upon startup

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Zac C (:zac)]

Attachment: sms_indexeddb_death.txt

The SMS data pushed to the device by makeRefenceWorkload.sh is causing Gaia to fail to start.

This is in turn causing all perf tests to fail.



B2G-inbound pushlog:
https://hg.mozilla.org/integration/b2g-inbound/pushloghtml?startID=11364&endID=11365

first failing build:
Gaia-Rev        4f86c631e0465c0e56ccebeb1324fd28be9ea32f
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/54217864bae9
Build-ID        20141013190501
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141013.222715
FW-Date         Mon Oct 13 22:27:26 EDT 2014
Bootloader      L1TC00011840

Comment 1

[Zac C (:zac)]

Jon, can you look into this, see whether it's a bug in Gecko or the reference db we're pushing to the device is outdated?

Comment 2

[Jan Varga [:janv]]

Can someone provide a directory listing of the SMS data pushed to the device ?

Comment 3

[Zac C (:zac)]

Jan, it's all in here:

https://github.com/mozilla-b2g/gaia/tree/master/test_media/reference-workload

as:
smsDb-x.sqlite

makeReferenceWorkload.sh is the script that prepares and pushes to the device.

Comment 4

[Jan Varga [:janv]]

Note that we added a suffix to the directory where IndexedDB stores blobs.

For example, we used to have:
2479791906utpsgerta_de/
2479791906utpsgerta_de.sqlite

Now it is:
2479791906utpsgerta_de.files/
2479791906utpsgerta_de.sqlite

Comment 5

[Zac C (:zac)]

OK that's the problem.
I'll prepare a fix.

Comment 6

[Zac C (:zac)]

Attachment: github pr

Comment 7

[Jon Hylands [:jhylands]]

Comment on attachment 8504729 [details] [review]
github pr

This looks great... Thanks Zac

Comment 8

[Zac C (:zac)]

Thanks!

Merged:
https://github.com/mozilla-b2g/gaia/commit/b77e6392593c4267cf2146e2a184217d7e5ca828

Comment 9

[Julien Wajsberg [:julienw]]

I think the fix should have been:

* keep the old way (anyway Gecko is converting the locations)
* but clean up (rm -rf) old directories

This way the same script works on all versions of Firefox OS.

Jon, what do you think of this? I can file a separate bug to do this if you want.

Comment 10

[Jon Hylands [:jhylands]]

Julien - honestly, its been so long since I did anything with reference workloads. If you think you have a better way to solve whatever the original problem was, then have at it :-)

Comment 11

[Jan Varga [:janv]]

(In reply to Julien Wajsberg [:julienw] (PTO -> Apr 27) from comment #9)
> I think the fix should have been:
> 
> * keep the old way (anyway Gecko is converting the locations)
> * but clean up (rm -rf) old directories
> 
> This way the same script works on all versions of Firefox OS.
> 
> Jon, what do you think of this? I can file a separate bug to do this if you
> want.

Well, that should work too (if having the same script is important).

Comment 12

[Julien Wajsberg [:julienw]]

ok I'll work on this when I find some minutes :)