Closed Bug 108256 Opened 23 years ago Closed 23 years ago

Cancelling an auto-sub confirm dialog, then running the same url again, fails.

Categories

(SeaMonkey :: MailNews: Message Display, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: stephend, Assigned: sspitzer)

References

Details

Attachments

(1 file)

Build ID:  2001-11-02, Windows 2000.

Summary:  Cancelling an auto-sub confirm dialog, then running the same url 
again, fails.

Steps to Reproduce:

1.  Run news://news.mozilla.org/netscape.public.mozilla.mail-news
2.  You'll get a dialog, asking you to confirm the subscription.
3.  Do a cancel.
4.  Go back to the browser window, and run the auto-subscription url again..

Expected Results:

We should popup the dialog in the case where we haven't subscribed to it yet.

Actual Results:

We silently fail to do anything.
QA Contact: esther → stephend
Summary: Cancelling an auto-sub confirm dialog, then running the same url again, fails. → Cancelling an auto-sub confirm dialog, then running the same url again, fails.
ok, I see the problem.

it's the way we leave nntp connection when you hit cancel.
another problem is that autosubscribe urls are ending up in the cache

which is a problem that existed before hwaara checked in.

taking.
Assignee: hwaara → sspitzer
I was aware of this problem, and as seth says it existed before my patch landed.

The problem is that we cache urls that we shouldn't cache. I was thinking of
just checking what kind of URL we dealt with and then decide whether to cache,
but noticed that we _always_ cache the URL before we even know what kind of URL
we're dealing with.

I suspect the fix is to move url parsing to ParseUrl(), where it should be.
Currently, we parse urls in LoadUrl() - which is just plain wrong.
Comment on attachment 56347 [details] [diff] [review]
hack for now, until news is cleaned up

sr=bienvenu
Attachment #56347 - Flags: superreview+
Comment on attachment 56347 [details] [diff] [review]
hack for now, until news is cleaned up

I wouldn't consider this a 'real' fix for the cache issue, but OK for now.  Can you but the bug# in the comment (FIXME) too?

r=hwaara
Attachment #56347 - Flags: review+
yes, I know it's it's just hacking around problems with how news works.

http://bugzilla.mozilla.org/show_bug.cgi?id=108294
http://bugzilla.mozilla.org/show_bug.cgi?id=108293

logged.  I've included those #s in the comment.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Verified FIXED with builds:

Mac OS 9.1 - 2001-11-07-08
Windows 2K - 2001-11-07-03
RedHat 7.2 - 2001-11-07-08
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
Depends on: 529253
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: