Disable Edit and Remove buttons on Tag Manager when there is no selection

RESOLVED FIXED in Thunderbird 36.0

Status

Thunderbird
Preferences
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Javi Rueda, Assigned: Javi Rueda)

Tracking

({polish})

Trunk
Thunderbird 36.0
polish

Thunderbird Tracking Flags

(thunderbird36 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Steps to Reproduce:
-------------------
1. Open Tag Manager on Preferences/Display
2. There should be some tags in a list-box. Don't select any of them.
3. Press Edit button or Remove button.

What happens
------------
Nothing (in fact, that is right!)

Results expected
----------------
Neither Edit nor Remove buttons should be clickable when no action will be performed after the click event.
(Assignee)

Comment 1

4 years ago
Created attachment 8522495 [details] [diff] [review]
Disable Edit and Remove buttons on Tag Manager when there is no selection
Attachment #8522495 - Flags: review?(mkmelin+mozilla)
(Assignee)

Updated

4 years ago
Assignee: nobody → leofigueres
Status: NEW → ASSIGNED

Comment 2

4 years ago
Comment on attachment 8522495 [details] [diff] [review]
Disable Edit and Remove buttons on Tag Manager when there is no selection

Review of attachment 8522495 [details] [diff] [review]:
-----------------------------------------------------------------

Nice polish, thx Javi! r=mkmelin

"let" is generally perferred over "var" for new code, though personally I don't care that much.
If you want you can also inline the listBox and btnRemove usage, e.g. document.getElementById("removeTagButton").disabled = .....

::: mail/components/preferences/display.js
@@ +241,5 @@
>                   "chrome,titlebar,modal",
>                   args);
> +  },
> +
> +  OnSelect: function()

please use lowerCamelCase for function names
Attachment #8522495 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 8523926 [details] [diff] [review]
patch v1.0.1
(Assignee)

Updated

4 years ago
Attachment #8522495 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed

Comment 4

4 years ago
https://hg.mozilla.org/comm-central/rev/b43cb16978c8 -> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0

Updated

4 years ago
Keywords: checkin-needed
status-thunderbird36: --- → fixed
You need to log in before you can comment on or make changes to this bug.