1082607 - Disable Edit and Remove buttons on Tag Manager when there is no selection

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Javi Rueda :javirid]

Steps to Reproduce:
-------------------
1. Open Tag Manager on Preferences/Display
2. There should be some tags in a list-box. Don't select any of them.
3. Press Edit button or Remove button.

What happens
------------
Nothing (in fact, that is right!)

Results expected
----------------
Neither Edit nor Remove buttons should be clickable when no action will be performed after the click event.

Comment 1

[Javi Rueda :javirid]

Attachment: Disable Edit and Remove buttons on Tag Manager when there is no selection

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8522495 [details] [diff] [review]
Disable Edit and Remove buttons on Tag Manager when there is no selection

Review of attachment 8522495 [details] [diff] [review]:
-----------------------------------------------------------------

Nice polish, thx Javi! r=mkmelin

"let" is generally perferred over "var" for new code, though personally I don't care that much.
If you want you can also inline the listBox and btnRemove usage, e.g. document.getElementById("removeTagButton").disabled = .....

::: mail/components/preferences/display.js
@@ +241,5 @@
>                   "chrome,titlebar,modal",
>                   args);
> +  },
> +
> +  OnSelect: function()

please use lowerCamelCase for function names

Comment 3

[Javi Rueda :javirid]

Attachment: patch v1.0.1

Comment 4

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/b43cb16978c8 -> FIXED