108263 - libeditor should build both plain and html by default

Status: RESOLVED INVALID

(Core :: DOM: Editor, task)

Description

[Akkana Peck]

Currently, on linux, libeditor can build a text-only library or a text-and-html
one.  Windows builds both versions, which is better since it guards against
bitrot in the plaintext-only library.  Linux should do this, too.

Comment 1

[Akkana Peck]

Attachment: Patch to build both libraries (or just text)

Patch: by default, build both libeditor.so and libtexteditor.so.
If MOZ_PLAINTEXT_EDITOR_ONLY (configure option) is set, build only
libtexteditor.so.

Comment 2

[Akkana Peck]

Kin, does this patch look reasonable to build both plaintext and full editor
libraries, like you're doing on Windows?

Comment 3

[Akkana Peck]

Kin and I have been going over some issues.  He came up with a much better way
to do it which doesn't use the precarious dependencies.  I'll attach a better patch.

However, it seems that Cathleen disabled the Windows version of this because it
was causing problems with the static builds (bug 111062, makefile.win 1.7-1.8).
 Unix will probably have the same problem.  So let's not try to rush it in for
0.9.7; I'm bumping the TM by one, and that'll give us all a chance to get this
working on both platforms for the static as well as shared builds.

Kin suggests: "The thing to do to make this work is to lose the HTML
transactions in libeditor/base, that is, move them to html where they should be."

Comment 4

[Akkana Peck]

Attachment: Better, cleaner patch for linux build

Comment 5

[Akkana Peck]

Everybody's been on vacation and there doesn't seem much chance that we'll get
together to come up with a plan in time for 0.9.8.  Sigh.

Comment 6

[Syd Logan]

futuring 

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)

Comment 8

[Akkana Peck]

Removing myself as assignee for editor bugs, since the editor project is (sadly) long gone.

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

This was about Composer/Editor App, not the current DOM:Editor scope.