Closed Bug 1082632 Opened 5 years ago Closed 5 years ago

Enable Valence add-on auto-install

Categories

(DevTools :: WebIDE, defect)

defect
Not set

Tracking

(relnote-firefox 37+)

RESOLVED FIXED
Firefox 37
Tracking Status
relnote-firefox --- 37+

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1081093 adds auto-install support for the tools adapter add-on, but leaves it disabled for now.

Once the add-on is ready for wider distribution, we should flip it on.
Ready for review, but don't land yet, as there still changes to make to the add-on first.

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a84debbe2576
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8509514 - Flags: review?(paul)
Attachment #8509514 - Flags: review?(paul) → review+
Comment on attachment 8509514 [details] [diff] [review]
Enable auto-install tools adapter add-on

Let me take that back.

If we land that in Aurora, it will go to beta and release without going through nightly. I'm not even sure we want this to be enabled in vanilla firefox.
Attachment #8509514 - Flags: review+
Well, we could put it in the Aurora-only prefs, so it's fixed for Dev Edition only.

Or, the current patch could land in Nightly (and be uplifted to Aurora), and keep riding the trains up to Release.

Dave, what's your opinion?  Should Valence / Fever Dream auto-install be Dev Edition only, or ride the trains and install on WebIDE open for any channel eventually?
Flags: needinfo?(dcamp)
(In reply to J. Ryan Stinnett [:jryans] from comment #3)
> Well, we could put it in the Aurora-only prefs, so it's fixed for Dev
> Edition only.

Let's do that for now.
Flags: needinfo?(dcamp)
(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #4)
> (In reply to J. Ryan Stinnett [:jryans] from comment #3)
> > Well, we could put it in the Aurora-only prefs, so it's fixed for Dev
> > Edition only.
> 
> Let's do that for now.

This will happen in bug 1082584.
Comment on attachment 8509514 [details] [diff] [review]
Enable auto-install tools adapter add-on

Let's land in Firefox Nightly after we got some feedback from devedition ... ironic :)
Attachment #8509514 - Flags: review+
Okay, sounds fine.  This bug no longer blocks Dev Edition then.
No longer blocks: fx-dev-edition, 1082509
Dave / Axel / Jeff, should we proceed with Valence auto-install on WebIDE open in all channels, or leave it restricted to Dev Edition?
Flags: needinfo?(jgriffiths)
Flags: needinfo?(dcamp)
Flags: needinfo?(akratel)
I think if they've opened WebIDE, then sure.
Flags: needinfo?(jgriffiths)
I concurr, if they've opened WebIDE, then go ahead and auto install.
Flags: needinfo?(akratel)
Attachment #8538781 - Flags: review?(paul) → review+
Keywords: checkin-needed
Hi, this patch failed to apply:

adding 1082632 to series file
renamed 1082632 -> 0001-Bug-1082632-Enable-Valence-auto-install-for-all-chan.patch
applying 0001-Bug-1082632-Enable-Valence-auto-install-for-all-chan.patch
patching file browser/devtools/webide/webide-prefs.js
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file browser/devtools/webide/webide-prefs.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 0001-Bug-1082632-Enable-Valence-auto-install-for-all-chan.patch

could you take a look, thanks!
Flags: needinfo?(jryans)
Rebase, pushed to fx-team:

https://hg.mozilla.org/integration/fx-team/rev/43596e7e4086
Flags: needinfo?(jryans)
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/43596e7e4086
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
relnoted as "Debug tabs in Chrome Desktop, Chrome for Android, and Safari for iOS".
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #16)
> relnoted as "Debug tabs in Chrome Desktop, Chrome for Android, and Safari
> for iOS".

I realize I wrote this wording...  

But I think adding "opened" as in "Debug tabs opened in Chrome Desktop, Chrome for Android, and Safari for iOS" is better, to make it clearer that the *debugging* takes place in Firefox, not in the other browsers somehow.
Flags: needinfo?(lmandel)
OK. Makes sense to me. I have updated the note. Thanks for the improvement.
Flags: needinfo?(lmandel)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.