1082650 - Utility tray must consider software home button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Guillaume Marty [:gmarty]]

Bug 1061969 introduced an improved utility tray animation but there are issues when the software home button is enabled.
On portrait mode, the notifications container jumps while being animated.
On landscape mode, the notifications are crop on the right.

Comment 1

[Guillaume Marty [:gmarty]]

Attachment: Github PR

Vivien, can you review this patch?

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

[Blocking Requested - why for this release]:

Blocks a blocker.

Comment 3

[Gregor Wagner [:gwagner]]

Regression from another blocker.

Comment 4

[Gregor Wagner [:gwagner]]

Lets see if we uplift the bug that caused this regression.

Comment 5

[Guillaume Marty [:gmarty]]

Landed in https://github.com/mozilla-b2g/gaia/commit/6446367dc9d701c178e09189f82525dfff1cc894

Comment 6

[Duane Dixon [:ddixon]]

Issue is verified fixed in build Flame 2.1 (Full Flash, nightly). 

Actual Results: Notification tray animates correctly in portrait and landscape orientations. 

Device: Flame 2.1
Build ID: 20141021001201
Gaia: e458f5804c0851eb4e93c9eb143fe044988cecda
Gecko: ee86921a986f
Version: 34.0 (2.1)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
----------------------------------------
----------------------------------------
Issue DOES occur in Flame 2.2 (Full Flash, nightly).

Actual Results: Notification tray animation is choppy and distorted when swiped down and up in portrait orientation while Software Home Button is enabled.  

Device: Flame Master
Build ID: 20141021040206
Gaia: 457a54fc3200b80e4f5e1cd3acaa062309230732
Gecko: 29fbfc1b31aa
Version: 36.0a1 (Master)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0


Leaving 'Status: Resolved Fixed' until issue is addressed in Flame 2.2 (Master).

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

The reason this doesn't show up in 2.1 is because bug 1061969 was never uplifted. If it is not working on master, we need to re-investigate.

> Actual Results: Notification tray animation is choppy and distorted 
> when swiped down and up in portrait orientation while Software Home Button is enabled.  

Duane, can you be more specific about what you mean here?

Comment 8

[Duane Dixon [:ddixon]]

Here is a video of what I am seeing. Hope this helps!

Video: http://youtu.be/L-0QHFxFE_I

Full Flash, Nightly, 512 MB memory. 

Environmental Variables:
Device: Flame Master
Build ID: 20141022040201
Gaia: 4d7f051cede6544f4c83580253c743c22b0cb279
Gecko: ae4d9b4ff2ee
Version: 36.0a1 (Master)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 9

[Gregor Wagner [:gwagner]]

(In reply to Duane Dixon [:ddixon] from comment #8)
> Here is a video of what I am seeing. Hope this helps!
> 
> Video: http://youtu.be/L-0QHFxFE_I
> 

I just saw the same issue on 2.1 with the twitter app (pulling down the utility tray over fresh installed twitter app). I guess we need a separate bug for it.

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Duane Dixon [:ddixon] from comment #8)
> Here is a video of what I am seeing. Hope this helps!
> 
> Video: http://youtu.be/L-0QHFxFE_I
> 
> Full Flash, Nightly, 512 MB memory. 
> 
> Environmental Variables:
> Device: Flame Master
> Build ID: 20141022040201
> Gaia: 4d7f051cede6544f4c83580253c743c22b0cb279
> Gecko: ae4d9b4ff2ee
> Version: 36.0a1 (Master)
> Firmware Version: v188
> User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Guillaume, can you take a look here? If this is a new issue, please file a separate bug and re-close this one.

Comment 11

[Guillaume Marty [:gmarty]]

I opened Bug 1088057 as this issue is different than the one described here.