Closed Bug 108268 Opened 18 years ago Closed 18 years ago

WebBrowserPersist ever uncompress files

Categories

(Core Graveyard :: Embedding: APIs, defect)

x86
Other
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla0.9.6

People

(Reporter: mpgritti, Assigned: adamlock)

References

Details

Attachments

(1 file)

We are using WebBrowserPersist to download files in galeon.
The problem is that all .gz files are uncompressed.

It would be great if we could

httpChannel->SetApplyConversion(PR_FALSE)

in SaveURIInternal. Or extend the api with a boolean flag
about this.

We are very near to 1.0 and this is a major galeon bug. 
Please let me know if this is possible, I can provide a patch if
you like.
Blocks: 98992
Blocks: 98995
No longer blocks: 98992
Status: UNCONFIRMED → NEW
Ever confirmed: true
Hi,

Can you try out this patch and see if it is a suitable solution to your problems?

Also note that (in theory but I havent tested) your progress listener will be
called progress notifications for the the nsIRequest that you initiated via
SaveURI. It should be possible to call SetApplyConversion(PR_FALSE) during the
first such callback but admittedly this is a bit of a pain.
Comment on attachment 56563 [details] [diff] [review]
Patch disables content conversion

r=bryner
Attachment #56563 - Flags: review+
Comment on attachment 56563 [details] [diff] [review]
Patch disables content conversion

sr=blizzard
Attachment #56563 - Flags: superreview+
Despite the lack of feedback I have checked in the fix to catch the 0.9.6 boat. 

Please reopen if you still have problems.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla0.9.6
Sorry for the lack of feedback. I've been away for some days. Thank you a lot 
for the quick fix !
QA Contact: mdunn → depstein
changed qa contact to Dharma.
QA Contact: depstein → dsirnapalli
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.