108268 - WebBrowserPersist ever uncompress files

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Marco Pesenti Gritti]

We are using WebBrowserPersist to download files in galeon.
The problem is that all .gz files are uncompressed.

It would be great if we could

httpChannel->SetApplyConversion(PR_FALSE)

in SaveURIInternal. Or extend the api with a boolean flag
about this.

We are very near to 1.0 and this is a major galeon bug. 
Please let me know if this is possible, I can provide a patch if
you like.

Comment 1

[Adam Lock]

Attachment: Patch disables content conversion

Comment 2

[Adam Lock]

Hi,

Can you try out this patch and see if it is a suitable solution to your problems?

Also note that (in theory but I havent tested) your progress listener will be
called progress notifications for the the nsIRequest that you initiated via
SaveURI. It should be possible to call SetApplyConversion(PR_FALSE) during the
first such callback but admittedly this is a bit of a pain.

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 56563 [details] [diff] [review]
Patch disables content conversion

r=bryner

Comment 4

[Christopher Blizzard (:blizzard)]

Comment on attachment 56563 [details] [diff] [review]
Patch disables content conversion

sr=blizzard

Comment 5

[Adam Lock]

Despite the lack of feedback I have checked in the fix to catch the 0.9.6 boat. 

Please reopen if you still have problems.

Comment 6

[Marco Pesenti Gritti]

Sorry for the lack of feedback. I've been away for some days. Thank you a lot 
for the quick fix !

Comment 7

[David Epstein]

changed qa contact to Dharma.