Closed
Bug 1082792
Opened 10 years ago
Closed 9 years ago
Build firefox.exe with -MD in ASAN builds
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file, 1 obsolete file)
1.84 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Mixing -MT and -MD as we do by default is not a supported configuration for ASAN. Given that we don't require supporting XP SP2 in those builds, we can opt out of this.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8504975 [details] [diff] [review] Build firefox.exe with -MD in ASAN builds David, I'd appreciate if you could give feedback on this, as discussed on IRC last week. Asking glandium for the actual review.
Attachment #8504975 -
Flags: review?(mh+mozilla)
Attachment #8504975 -
Flags: feedback?(dmajor)
Comment on attachment 8504975 [details] [diff] [review] Build firefox.exe with -MD in ASAN builds If it works, I have no objection. I assume you don't care about exes other than firefox?
Attachment #8504975 -
Flags: feedback?(dmajor) → feedback+
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to David Major [:dmajor] (UTC+13) from comment #3) > Comment on attachment 8504975 [details] [diff] [review] > Build firefox.exe with -MD in ASAN builds > > If it works, I have no objection. It works. :-) > I assume you don't care about exes other than firefox? firefox.exe is the only thing I have tested so far. If you meant other exes as in Thunderbird/etc, I don't care about them yet.
Comment 5•10 years ago
|
||
Comment on attachment 8504975 [details] [diff] [review] Build firefox.exe with -MD in ASAN builds Review of attachment 8504975 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/app/moz.build @@ +33,5 @@ > DELAYLOAD_DLLS += [ > 'mozglue.dll', > ] > +if not CONFIG['MOZ_ASAN']: > + USE_STATIC_LIBS = True What about all the other USE_STATIC_LIBS in the tree? Can that wait that I'm done with bug 1077148? because I'm sure I'd break you.
Assignee | ||
Comment 6•10 years ago
|
||
I'll wait for bug 1077148. Note to self: patches to try: https://hg.mozilla.org/try/rev/be678d72b34a https://hg.mozilla.org/try/rev/a380ed753b8c
Depends on: 1077148
Assignee | ||
Updated•10 years ago
|
Attachment #8504975 -
Attachment is obsolete: true
Attachment #8504975 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 7•10 years ago
|
||
Mixing -MT and -MD as we do by default is not a supported configuration for ASAN. Given that we don't require supporting XP SP2 in those builds, we can opt out of this.
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8515010 [details] [diff] [review] Build firefox.exe with -MD in ASAN builds; r=glandium This is now on top of bug 1077148. That bug simplified this patch a lot!
Attachment #8515010 -
Flags: review?(mh+mozilla)
Comment 9•10 years ago
|
||
Comment on attachment 8515010 [details] [diff] [review] Build firefox.exe with -MD in ASAN builds; r=glandium Review of attachment 8515010 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/app/nsBrowserApp.cpp @@ +40,5 @@ > +#ifdef MOZ_ASAN > +// ASAN requires firefox.exe to be built with -MD, and it's OK if we don't > +// support Windows XP SP2 in ASAN builds. > +#define XRE_DONT_SUPPORT_XPSP2 > +#endif Why metro builds aren't doing this instead of what was done in bug 1080388 is beyond me.
Attachment #8515010 -
Flags: review?(mh+mozilla) → review+
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a0f54a85aec4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•