108280 - OS/2 support for bug 99010

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[jhp (no longer active)]

Take changes from font bug 99010.  Approximate win32 code.

Comment 1

[jhp (no longer active)]

Attachment: patch

Comment 2

[jhp (no longer active)]

This patch contains all the necessary changes to gfx/src/os2.  Also, I 
decided to take the win32 path in nsIRenderingContext.h and 
nsTextFrame.cpp

Comment 3

[jhp (no longer active)]

Attachment: updated patch

Comment 4

[jhp (no longer active)]

Reassigning to mkaply

Comment 5

[jhp (no longer active)]

In the latest patch, implemented gLoadedFonts (rather than keeping around a
global font list of all the installed fonts), and cleanup up code.

Comment 6

[jhp (no longer active)]

Attachment: better patch

Cannot use array of loaded fonts, since there is no reliable way to query all
font metrics belonging to given familyname (rather than facename).  Therefore,
had to go back to using global font list.  Instead of keeping all FONTMETRICS
around for every facename, created a minifontmetrics stucture that just holds
the info I need in order to cut back memory footprint.	Also took
FontCleanupObserver from nsFontMetricsWin, so globals are only freed on
shutdown.

Comment 7

[Kunihiko Aizawa]

In preferences/fonts, warpzilla had listed up several typrface for MINCHO
font as follows:
"MINCHO"
"MINCHO Proportional"
"MINCHO System"
"MINCHO Terminal"....
however, warpzilla 2001113011 and later builds (and 0.9.6) have listed
only "MINCHO". No other MINCHOs with substyle like as "MINCHO Proportional"
are available. Same things happen on GOTHIC. Is this an influence of the
last patch?

Comment 8

[jhp (no longer active)]

Attachment: fix russian text wrapping

This patch should fix some issues with test wrapping.  I forgot to check the
return value in ResolveForwards/Backwards, to see whether we should continue
parsing the string.  I also took some changes that were added to the windows
version of the files.

Comment 9

[jhp (no longer active)]

Fix checked in.  I'll close this bug when the MINCHO fix gets checked in.

Comment 10

[Mike Kaply [:mkaply]]

*** Bug 120532 has been marked as a duplicate of this bug. ***

Comment 11

[jhp (no longer active)]

Attachment: mincho fix

This fixes the Mincho problem reported earlier.  We can close this bug as soon
as this is checked in.

Comment 12

[Mike Kaply [:mkaply]]

Mincho fix checked in.

Comment 13

[Kunihiko Aizawa]

Warpzilla 2002020408 lists up all Mincho/Gothic fonts properly
in preferences/fonts/typeface.
Many thanks,

Comment 14

[Mike Kaply [:mkaply]]

Verified - new font stuff is in and customer verified JP fix.