gtk_widget_hide called with NULL, crashes installer on clicking install button

VERIFIED FIXED in mozilla1.0

Status

SeaMonkey
Installer
--
critical
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: Nidheesh Dubey, Assigned: Syd Logan)

Tracking

({crash})

Trunk
mozilla1.0
Sun
Solaris
crash

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

17 years ago
From Bugzilla Helper:


The code in mozilla/xpinstall/wizard/unix/src2/nsInstallDlg.cpp calls
gt_widget_hide on NULL if all xpi's are locally available and are NOT REQUIRED
TO BE DOWNLOADED. On clicking install button under gtk 1.2.10 this shows up as
installer crash. Method InitInstallProgress assumes that sDLProgressbar.vbox is
a valid created widget (done in InitDLProgress if download is required.)

nsInstallDlg::InitInstallProgress()
{
    gtk_widget_hide(sDLProgress.vbox);
    gCtx->idlg->ShowTable();
}

This code should be changed to 
if (sDLProgress.vbox)
	gtk_widget_hide(sDLProgress.vbox);

and the crash goes away. In gtk 1.2.6 this does not show up. Nonethless this is
a simple fix and the caller of gtk_widget_hide can also correct the code and not
just assume that toolkit will take care.

Reproducible: Always
Steps to Reproduce:
1.run mozilla-installer and keep all xpi pkgs in the subdirectory xpi. (copy
them locally)
2.choose install location etc and hit install. 
3.if you have 1.2.10 supplied in Solaris it crashes in InstallProgress

Actual Results:  crashes in InstallProgress with null parameter

Expected Results:  install should go thru without needing any download

Updated

17 years ago
QA Contact: bugzilla → ktrina
Severity: normal → critical
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: crash
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Keywords: nsbeta1+
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 1

16 years ago
Created attachment 68258 [details] [diff] [review]
patch
(Assignee)

Comment 2

16 years ago
Created attachment 68259 [details] [diff] [review]
patch
(Assignee)

Comment 3

16 years ago
Created attachment 68260 [details] [diff] [review]
patch
Comment on attachment 68259 [details] [diff] [review]
patch

r=bryner
Attachment #68259 - Flags: review+
Comment on attachment 68259 [details] [diff] [review]
patch

sr=dveditz
Attachment #68259 - Flags: superreview+
(Assignee)

Comment 6

16 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 7

16 years ago
Verified code fix
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.