Closed
Bug 1082839
Opened 10 years ago
Closed 10 years ago
WebIDL for WindowRoot
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: smaug, Assigned: smaug)
Details
Attachments
(2 files)
5.03 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
4.99 KB,
patch
|
Details | Diff | Splinter Review |
For this case we probably should use privileged junkscope global as the parent.
Assignee | ||
Comment 1•10 years ago
|
||
bholley, I need a parent for the WindowRoot, but the parent can't be any Window object, since WindowRoot lives outside the Windows (it is the top level object in EventTarget hierarchy, even higher than the top level chrome Window), so I hope you don't object using privileged junk scope as the parent object.
Flags: needinfo?(bobbyholley)
Assignee | ||
Comment 2•10 years ago
|
||
This should give WindowRoot rather normal interface object in chrome. https://tbpl.mozilla.org/?tree=Try&rev=b425532ca447
Attachment #8505047 -
Flags: review?(peterv)
Comment 3•10 years ago
|
||
Why don't you use [NoInterfaceObject]? Is the global property "WindowRoot" needed in chrome?
Assignee | ||
Comment 4•10 years ago
|
||
I don't really care too strongly about that, but for the consistency with other EventTarget objects I didn't use NoInterfaceObject.
Comment 5•10 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #1) > bholley, I need a parent for the WindowRoot, but the parent can't be any > Window object, since > WindowRoot lives outside the Windows (it is the top level object in > EventTarget hierarchy, even higher than the top level chrome Window), so I > hope you don't object using privileged junk scope as the parent object. Yes, that sounds sensible to me. Please annotate my approval in a comment.
Flags: needinfo?(bobbyholley)
Comment 6•10 years ago
|
||
Comment on attachment 8505047 [details] [diff] [review] WindowRoot_webidl.diff Review of attachment 8505047 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bindings/Bindings.conf @@ +1463,5 @@ > }], > > +'WindowRoot': { > + 'nativeType': 'nsWindowRoot', > + 'headerFile': 'nsWindowRoot.h' Don't think you need the headerFile.
Attachment #8505047 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f10b55f5a819
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f10b55f5a819
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•