Closed Bug 1082839 Opened 5 years ago Closed 5 years ago

WebIDL for WindowRoot

Categories

(Core :: DOM: Core & HTML, defect)

34 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(2 files)

For this case we probably should use privileged junkscope global as the parent.
bholley, I need a parent for the WindowRoot, but the parent can't be any Window object, since
WindowRoot lives outside the Windows (it is the top level object in EventTarget hierarchy, even higher than the top level chrome Window), so I hope you don't object using privileged junk scope as the parent object.
Flags: needinfo?(bobbyholley)
This should give WindowRoot rather normal interface object in chrome.

https://tbpl.mozilla.org/?tree=Try&rev=b425532ca447
Attachment #8505047 - Flags: review?(peterv)
Why don't you use [NoInterfaceObject]? Is the global property "WindowRoot" needed in chrome?
I don't really care too strongly about that, but for the consistency with other EventTarget objects
I didn't use NoInterfaceObject.
(In reply to Olli Pettay [:smaug] from comment #1)
> bholley, I need a parent for the WindowRoot, but the parent can't be any
> Window object, since
> WindowRoot lives outside the Windows (it is the top level object in
> EventTarget hierarchy, even higher than the top level chrome Window), so I
> hope you don't object using privileged junk scope as the parent object.

Yes, that sounds sensible to me. Please annotate my approval in a comment.
Flags: needinfo?(bobbyholley)
Comment on attachment 8505047 [details] [diff] [review]
WindowRoot_webidl.diff

Review of attachment 8505047 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Bindings.conf
@@ +1463,5 @@
>  }],
>  
> +'WindowRoot': {
> +    'nativeType': 'nsWindowRoot',
> +    'headerFile': 'nsWindowRoot.h'

Don't think you need the headerFile.
Attachment #8505047 - Flags: review?(peterv) → review+
Attached patch v2Splinter Review
https://hg.mozilla.org/mozilla-central/rev/f10b55f5a819
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.