Closed
Bug 1082843
Opened 10 years ago
Closed 10 years ago
Global xpcshell head.js shouldn't import Promise.jsm into the global scope
Categories
(Testing :: XPCShell Harness, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(2 files)
1.22 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
2.63 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
Right now it's doing that.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8505025 -
Flags: review?(dteller)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=39d2287742c8
Comment 3•10 years ago
|
||
Comment on attachment 8505025 [details] [diff] [review] Don't import Promise.jsm into the global scope in xpcshell tests Review of attachment 8505025 [details] [diff] [review]: ----------------------------------------------------------------- Oops. Good catch.
Attachment #8505025 -
Flags: review?(dteller) → review+
Assignee | ||
Comment 4•10 years ago
|
||
There are several test failures: 1) browser/components/loop/test/xpcshell/test_loopservice_dnd.js uses Promise.defer, which is non-standard. 2) browser/components/loop/test/xpcshell/test_loopservice_notification.js -- same thing 3) browser/components/loop/test/xpcshell/test_loopservice_busy.js -- same thing 4) extensions/cookie/test/unit/test_permmanager_defaults.js -- same thing I'm going to fix them by using the hack Bobby did in bug 1065185 for marionette tests.
Assignee | ||
Comment 5•10 years ago
|
||
Or I guess I could make those tests explicitly import Promise.jsm
Assignee | ||
Comment 7•10 years ago
|
||
Er, and: 5) toolkit/modules/tests/xpcshell/test_sqlite_shutdown.js -- same thing
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8505163 -
Flags: review?(dteller)
Updated•10 years ago
|
Attachment #8505163 -
Attachment is patch: true
Updated•10 years ago
|
Attachment #8505163 -
Flags: review?(dteller) → review+
Assignee | ||
Comment 9•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=a4e9ad29f736
Assignee | ||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d343b4bb2bc0
Target Milestone: --- → mozilla36
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d343b4bb2bc0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•