nsCharsetConverterManager (uconv) depends on chardet

RESOLVED FIXED in mozilla0.9.7

Status

()

Core
Internationalization
P2
normal
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: Alec Flett, Assigned: Alec Flett)

Tracking

Trunk
mozilla0.9.7
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
there is only one tiny dependency which is causing uconv to depend on the
chardet module - in nsCharsetConverterManager, there is a function
GetCharsetDetectorList(), which enumerates registry entries.. and to get the
registry root, we need NS_CHARSET_DETECTOR_REG_BASE

the simple solution is to just replace the use of NS_CHARSET_DETECTOR_REG_BASE
with the raw character string, but it makes me wonder if
GetCharsetDetectorList() isn't in the wrong location. Maybe it should be in
nsICharsetDetector() instead...
(Assignee)

Comment 1

17 years ago
now that I know the default owner, reassigning to me

The reason that this is important is that this means anyone who pulls in uconv
pulls in chardet, and chardet is a very large module with many dependencies
Assignee: yokoyama → alecf
Priority: -- → P2
Target Milestone: --- → mozilla0.9.7
(Assignee)

Comment 2

17 years ago
Created attachment 56349 [details] [diff] [review]
the simple solution.. just replace the macro with the value
(Assignee)

Comment 3

17 years ago
this got fixed along with another bug
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 4

17 years ago
Changed QA contact to alecf@netscape.com.
QA Contact: teruko → alecf
You need to log in before you can comment on or make changes to this bug.