1082885 - [SHB] Input method prompt is overlapped by SHB

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

STR:

1.) Go to Settings->Keyboards and add a new keyboard (like Spanish)
2.) Go to Messages app, and bring up the keyboard
3.) Long press on the select language key (lower left)

Actual result:
SHB overlaps the keyboard select prompt.

Expected result:
SHB does not overlap the prompt.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [screenshot] bad prompt

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

[Blocking Requested - why for this release]:

It's unclear to me whether this dialog ever worked with the software home button, but even if it is not a regression it still looks pretty bad.

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

[Blocking Requested - why for this release]:

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia PR] make ime shb aware

Comment 5

[Gregor Wagner [:gwagner]]

Broken feature.

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8505079 [details] [review]
[Gaia PR] make ime shb aware

r=me with the comments on the test addressed

Comment 7

[KTucker [:KTucker][Inactive 3/4/2016]]

Adding qawanted for branch/regression check.

Comment 8

[Adam Alldredge [:AdamA][Inactive]]

This issue reproduces in 2.1 Flame and 2.2 Flame.

Environmental Variables:
Device: Flame 2.2 Master (Shallow Flash)
BuildID: 20141014171832
Gaia: 5f1f0960ae9d22acf2a324ad37a48174d6df87f6
Gecko: 62f0b771583c
Version: 36.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1 (Shallow Flash)
BuildID: 20141015040132
Gaia: 82565292c0fa86e3ddcda290cae7f5cb702f654c
Gecko: d8d578cb569c
Version: 34.0 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result:
The SHB is overlapping the the input method  prompt.
--------------------------------------------------------------------
This issue does not occur on 2.0 Flame.

Device: Flame 2.0 (Shallow Flash)
BuildID: 20141014194629
Gaia: c6c6116ca225c2c934220ae6867e5a3256d65e00
Gecko: 24a2aa6bf1c4
Gonk: 
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Result:
The input method prompt overlaps the SHB.(screenshot attached)

Comment 9

[Adam Alldredge [:AdamA][Inactive]]

Attachment: 2.0 SHB being overlapped.

Comment 10

[Gregor Wagner [:gwagner]]

(In reply to Adam Alldredge [:AdamA] from comment #9)
> Created attachment 8505681 [details]
> 2.0 SHB being overlapped.

Did you enable the SHB here? Thats the reverse to what we are seeing.

Comment 11

[Gregor Wagner [:gwagner]]

(In reply to KTucker [:KTucker] from comment #7)
> Adding qawanted for branch/regression check.

I don't think we need 2.0 checks for SHB bugs in the future. The feature existed before but 2.1 is the first official release that supports the SHB. We know that the feature had many bugs before that. This should save you some time :)

Comment 12

[Adam Alldredge [:AdamA][Inactive]]

Yes, I enabled the software home button in that image.

Comment 13

[Michael Henretty [:mikehenrty][:mhenretty]]

FTR, software home button was probably pretty broken in 2.0.

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/4a9252f6ff519ba0b6f6c137b30d2f769ab1fb58

Comment 15

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8505079 [details] [review]
[Gaia PR] make ime shb aware

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Not a regression, this screen never worked with SHB.

[User impact] if declined:
Poor UX when trying to switch input methods.

[Testing completed]:
Tested on device, and new integration test.

[Risk to taking this patch] (and alternatives if risky):
css only change, specific to IME dialog, tested with integration tests.

[String changes made]: none.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/b07caf833b5b0bba89d0db6f0fc6ca55f65c0537

Comment 17

[Brogan Zumwalt [Inactive]]

Issue verified fixed in Flame 2.1 and Flame 2.2

Actual Results: No part of the input method prompt screen is covered by the Software Home Button. Both the cancel button and the home button function correctly.

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141022001201
Gaia: 3d9cc667f4e929861a9a77c41096bbf5a9c1bde0
Gecko: 928b18f7d8ff
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141022040201
Gaia: 4d7f051cede6544f4c83580253c743c22b0cb279
Gecko: ae4d9b4ff2ee
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 36.0a1 (2.2)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0