1082928 - Theme drawable offset when tabs tray is first opened

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Actual: offset drawable

0) Install a theme
1) Click the tabs panel

Expected: The drawable is in place
Actual: The drawable is offset slightly. Clicking the remote tabs panel (but not the private tabs panel) will recenter the drawable (which lasts until the URL bar is pressed and perhaps other actions).

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Expected: non-offset drawable

Comment 2

[:Margaret Leibovic]

Thanks for filing this. I noticed this yesterday as well.

Is this a regression?

Comment 3

[Aaron Train [:aaronmt]]

Is this the same as bug 1082542 I saw the other day?

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Aaron Train [:aaronmt] from comment #3)
> Is this the same as bug 1082542 I saw the other day?

It might be the same cause.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to :Margaret Leibovic from comment #2)
> Is this a regression?

Unsure - I haven't checked. The LWT code probably hasn't changed since Sriram was here though, so if it's a regression, it's probably a pre-existing bug in the LWT code that new animations have uncovered.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Removing the lines in TabsPanel.prepareTabsAnimation that translate the tabs panel header fixes this bug (but obviously does not show the animation).

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Graphical glitch on rotation

I have seen similar graphical issues occur on rotation and during other animations.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8535277 [details]
Graphical glitch on rotation

Actually, I think this is a separate issue so I filed bug 1110555.

Comment 9

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.