Closed
Bug 1082937
Opened 11 years ago
Closed 11 years ago
Make firefoxtree compatible with Mercurial 3.2
Categories
(Developer Services :: Mercurial: firefoxtree, defect)
Developer Services
Mercurial: firefoxtree
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gps, Assigned: gps)
Details
Attachments
(2 files)
2.29 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
6.74 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
The removal of localrepository.push and localrepository.pull in Mercurial 3.2 (currently @) broke firefoxtree in multiple ways. We need some small patches to fix things.
Assignee | ||
Comment 1•11 years ago
|
||
Mercurial 3.2 (currently in @) introduces a "bookmarks" named argument
to exchange.push(). We add a **kwargs to handle it.
Attachment #8505126 -
Flags: review?(mh+mozilla)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gps
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•11 years ago
|
||
Mercurial 3.2 (currently in @) removed localrepository.pull in favor of
using exchange.pull directly. We refactor our code to favor
exchange.pull as well.
As part of this refactoring, we had to update references to the repo
from "self" to an argument. We also had to add the blocking checking for
"is firefox tree" into pull() since we now wrap a global function, not
a per-repo one.
Attachment #8505127 -
Flags: review?(mh+mozilla)
Comment 3•11 years ago
|
||
Comment on attachment 8505126 [details] [diff] [review]
firefoxtree: support Mercurial 3.2 version of exchange.push ()
Review of attachment 8505126 [details] [diff] [review]:
-----------------------------------------------------------------
::: hgext/firefoxtree/__init__.py
@@ +149,5 @@
> return '\n'.join(lines)
>
> +# **kwargs is here to support the "bookmarks" named argument, introduced in
> +# Mercurial 3.2. We can convert back to a named argument once we drop <3.2
> +# support.
For general future proofing, I think we should keep **kwargs on such hooks. IOW, I don't think we need this comment.
Attachment #8505126 -
Flags: review?(mh+mozilla) → review+
Updated•11 years ago
|
Attachment #8505127 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•