Closed Bug 1082957 Opened 5 years ago Closed 5 years ago

Make it possible to build the JS engine in debug mode without JS_CRASH_DIAGNOSTICS

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan.akhgari
Blocks: winasan
Attachment #8505146 - Flags: review?(wmccloskey)
Comment on attachment 8505146 [details] [diff] [review]
Make it possible to build the JS engine in debug mode without JS_CRASH_DIAGNOSTICS

Review of attachment 8505146 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jscntxtinlines.h
@@ +161,5 @@
>  
>  template <class T1> inline void
>  assertSameCompartmentDebugOnly(ThreadSafeContext *cx, const T1 &t1)
>  {
> +#ifdef JS_CRASH_DIAGNOSTICS

This needs to be #if defined(DEBUG) && defined(JS_CRASH_DIAGNOSTICS).
Attachment #8505146 - Flags: review?(wmccloskey) → review+
Ah, right!
https://hg.mozilla.org/mozilla-central/rev/3de05e0f076d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.