1082981 - Unfriendly failure mode in some cases when root can't be acquired on an Android device

Status: RESOLVED DUPLICATE of bug 1080761

(Testing :: Mochitest, defect)

Description

[Mike Hommey [:glandium]]

Error running mach:

    ['robocop']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

IndexError: list index out of range

  File "/home/glandium/mozilla-central/testing/mochitest/mach_commands.py", line 900, in run_robocop
    sys.exit(runtestsremote.main(args))
  File "/home/glandium/build/obj-arm-linux-androideabi/_tests/testing/mochitest/runtestsremote.py", line 604, in main
    dm = droid.DroidADB(deviceRoot=options.remoteTestRoot)
  File "/home/glandium/build/obj-arm-linux-androideabi/_tests/testing/mochitest/devicemanagerADB.py", line 68, in __init__
    self.connect()
  File "/home/glandium/build/obj-arm-linux-androideabi/_tests/testing/mochitest/devicemanagerADB.py", line 83, in connect
    self._checkForRoot()
  File "/home/glandium/build/obj-arm-linux-androideabi/_tests/testing/mochitest/devicemanagerADB.py", line 657, in _checkForRoot
    data = proc.output[0]

Comment 1

[Mike Hommey [:glandium]]

(and, as it turns out, running robocop tests doesn't require root)

Comment 2

[Mike Hommey [:glandium]]

Attachment: Don't error out in DeviceManagerADB._checkForRoot when su doesn't have any output

Comment 3

[William Lachance (:wlach)]

Hey, thanks for the patch, this was reported late last week and I have a patch pending. It fixes one more case that yours doesn't so I think we should go with that one.