docshell/base/nsDocShell.h:24:29: fatal error: ProfilerMarkers.h: No such file or directory (non-SPS)

RESOLVED FIXED in Firefox 36

Status

DevTools
Performance Tools (Profiler/Timeline)
RESOLVED FIXED
4 years ago
a month ago

People

(Reporter: Jan Beich, Assigned: tromey)

Tracking

Trunk
Firefox 36
All
FreeBSD

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
On platforms lacking SPS profiler (Linux/PPC, BSDs, Solaris) the build is broken because only GeckoProfiler.h is exported under tools/profiler/.

In file included from docshell/shistory/src/Unified_cpp_shistory_src0.cpp:29:
In file included from docshell/shistory/src/nsSHistory.cpp:27:
docshell/base/nsDocShell.h:24:10: fatal error:
      'ProfilerMarkers.h' file not found
#include "ProfilerMarkers.h"
         ^
1 error generated.

Updated

4 years ago
Assignee: nobody → ttromey
(Assignee)

Comment 1

4 years ago
Created attachment 8505471 [details] [diff] [review]
protect more code with MOZ_ENABLE_PROFILER_SPS

Sorry for the breakage :(

This patch protects the include with MOZ_ENABLE_PROFILER_SPS
and then the bit of code that required the new include.

I tested this by rebuilding with MOZ_ENABLE_PROFILER_SPS both
enabled and disabled.
(Assignee)

Updated

4 years ago
Attachment #8505471 - Flags: review?(bgirard)

Updated

4 years ago
Attachment #8505471 - Flags: review?(bgirard) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/8a7b0e87d26d
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8a7b0e87d26d
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).

dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)

Updated

a month ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.