Closed
Bug 1082990
Opened 10 years ago
Closed 10 years ago
docshell/base/nsDocShell.h:24:29: fatal error: ProfilerMarkers.h: No such file or directory (non-SPS)
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: jbeich, Assigned: tromey)
References
Details
Attachments
(1 file)
1.93 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
On platforms lacking SPS profiler (Linux/PPC, BSDs, Solaris) the build is broken because only GeckoProfiler.h is exported under tools/profiler/. In file included from docshell/shistory/src/Unified_cpp_shistory_src0.cpp:29: In file included from docshell/shistory/src/nsSHistory.cpp:27: docshell/base/nsDocShell.h:24:10: fatal error: 'ProfilerMarkers.h' file not found #include "ProfilerMarkers.h" ^ 1 error generated.
Updated•10 years ago
|
Assignee: nobody → ttromey
Assignee | ||
Comment 1•10 years ago
|
||
Sorry for the breakage :( This patch protects the include with MOZ_ENABLE_PROFILER_SPS and then the bit of code that required the new include. I tested this by rebuilding with MOZ_ENABLE_PROFILER_SPS both enabled and disabled.
Assignee | ||
Updated•10 years ago
|
Attachment #8505471 -
Flags: review?(bgirard)
Updated•10 years ago
|
Attachment #8505471 -
Flags: review?(bgirard) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8a7b0e87d26d
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8a7b0e87d26d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Comment 4•9 years ago
|
||
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline). dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•