On platforms lacking SPS profiler (Linux/PPC, BSDs, Solaris) the build is broken because only GeckoProfiler.h is exported under tools/profiler/. In file included from docshell/shistory/src/Unified_cpp_shistory_src0.cpp:29: In file included from docshell/shistory/src/nsSHistory.cpp:27: docshell/base/nsDocShell.h:24:10: fatal error: 'ProfilerMarkers.h' file not found #include "ProfilerMarkers.h" ^ 1 error generated.
Created attachment 8505471 [details] [diff] [review] protect more code with MOZ_ENABLE_PROFILER_SPS Sorry for the breakage :( This patch protects the include with MOZ_ENABLE_PROFILER_SPS and then the bit of code that required the new include. I tested this by rebuilding with MOZ_ENABLE_PROFILER_SPS both enabled and disabled.
Attachment #8505471 - Flags: review?(bgirard) → review+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline). dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
You need to log in before you can comment on or make changes to this bug.