Closed Bug 1082990 Opened 5 years ago Closed 5 years ago

docshell/base/nsDocShell.h:24:29: fatal error: ProfilerMarkers.h: No such file or directory (non-SPS)

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

All
FreeBSD
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: jbeich, Assigned: tromey)

References

Details

Attachments

(1 file)

On platforms lacking SPS profiler (Linux/PPC, BSDs, Solaris) the build is broken because only GeckoProfiler.h is exported under tools/profiler/.

In file included from docshell/shistory/src/Unified_cpp_shistory_src0.cpp:29:
In file included from docshell/shistory/src/nsSHistory.cpp:27:
docshell/base/nsDocShell.h:24:10: fatal error:
      'ProfilerMarkers.h' file not found
#include "ProfilerMarkers.h"
         ^
1 error generated.
Assignee: nobody → ttromey
Sorry for the breakage :(

This patch protects the include with MOZ_ENABLE_PROFILER_SPS
and then the bit of code that required the new include.

I tested this by rebuilding with MOZ_ENABLE_PROFILER_SPS both
enabled and disabled.
Attachment #8505471 - Flags: review?(bgirard)
Attachment #8505471 - Flags: review?(bgirard) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8a7b0e87d26d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).

dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.