1082993 - [settings] refactor Developer panel with AMD pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Refactor Device information panel with AMD pattern referring to
https://github.com/mozilla-b2g/gaia/tree/master/apps/settings

to make it modularize and more easier to maintain

Expected Results:

pass all settings test and act the same as original implementation

Comment 1

[[e-mail]]

including apps/settings/developer.js and developer_hud.js

Comment 2

[[e-mail]]

Attachment: pull request redirect to github

WIP

Comment 3

[[e-mail]]

Comment on attachment 8506782 [details] [review]
pull request redirect to github

yet another panel

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8506782 [details] [review]
pull request redirect to github

Fred, I just left some comments on the patch, please check them on GitHub

Thanks ! :)

Comment 5

[[e-mail]]

Comment on attachment 8506782 [details] [review]
pull request redirect to github

I've updated addressed issue and rebased the patch. Please kindly review it again.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8506782 [details] [review]
pull request redirect to github

These are last comments need to be addressed before r+, and I think we are almost there.

Thanks Fred ++

Comment 7

[[e-mail]]

Comment on attachment 8506782 [details] [review]
pull request redirect to github

update & tested on device, please kindly review it again

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8506782 [details] [review]
pull request redirect to github

Thanks Fred ! r+ with last nit addressed !

Comment 9

[[e-mail]]

fix last nit, thanks!

Comment 10

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/112c6b0f19aba9a86bfe314abdc9e8427e0e881c