[settings] refactor Developer panel with AMD pattern

RESOLVED FIXED in 2.2 S3 (9jan)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gasolin, Assigned: gasolin)

Tracking

unspecified
2.2 S3 (9jan)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=2])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Overview Description:

Refactor Device information panel with AMD pattern referring to
https://github.com/mozilla-b2g/gaia/tree/master/apps/settings

to make it modularize and more easier to maintain

Expected Results:

pass all settings test and act the same as original implementation
(Assignee)

Comment 1

4 years ago
including apps/settings/developer.js and developer_hud.js
(Assignee)

Updated

4 years ago
Assignee: nobody → gasolin
(Assignee)

Comment 2

4 years ago
Created attachment 8506782 [details] [review]
pull request redirect to github

WIP
(Assignee)

Comment 3

4 years ago
Comment on attachment 8506782 [details] [review]
pull request redirect to github

yet another panel
Attachment #8506782 - Flags: review?(ejchen)
Comment on attachment 8506782 [details] [review]
pull request redirect to github

Fred, I just left some comments on the patch, please check them on GitHub

Thanks ! :)
Attachment #8506782 - Flags: review?(ejchen)
(Assignee)

Comment 5

4 years ago
Comment on attachment 8506782 [details] [review]
pull request redirect to github

I've updated addressed issue and rebased the patch. Please kindly review it again.
Attachment #8506782 - Flags: review?(ejchen)
Comment on attachment 8506782 [details] [review]
pull request redirect to github

These are last comments need to be addressed before r+, and I think we are almost there.

Thanks Fred ++
Attachment #8506782 - Flags: review?(ejchen)
(Assignee)

Comment 7

4 years ago
Comment on attachment 8506782 [details] [review]
pull request redirect to github

update & tested on device, please kindly review it again
Attachment #8506782 - Flags: review?(ejchen)
Comment on attachment 8506782 [details] [review]
pull request redirect to github

Thanks Fred ! r+ with last nit addressed !
Attachment #8506782 - Flags: review?(ejchen) → review+
(Assignee)

Comment 9

4 years ago
fix last nit, thanks!
Keywords: checkin-needed
Whiteboard: [p=2]
Target Milestone: --- → 2.2 S3 (9jan)

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.