Closed
Bug 1083045
Opened 10 years ago
Closed 10 years ago
Scratchpad tests shouldn't depend on chrome debugging being disabled by default
Categories
(DevTools Graveyard :: Scratchpad, defect)
DevTools Graveyard
Scratchpad
Tracking
(firefox33 wontfix, firefox34 wontfix, firefox35 fixed, firefox36 fixed)
RESOLVED
FIXED
Firefox 36
People
(Reporter: past, Assigned: ochameau)
References
Details
Attachments
(1 file)
4.05 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
It's a common mistake to assume the world will always stay the same. Alas, as the oldest among us can attest, it never does.
Reporter | ||
Comment 1•10 years ago
|
||
Alex posted a patch for this in bug 1072181 comment 9, which I've moved to this bug and reviewed.
Attachment #8505282 -
Flags: review+
Reporter | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d4b2df21883d
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d4b2df21883d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8505282 [details] [diff] [review] scratchpad-tests.patch Approval Request Comment [Feature/regressing bug #]: it's a test improvement that will be required once we uplift some other patches that will make the failures permanent [User impact if declined]: none, only test failures [Describe test coverage new/current, TBPL]: existing tests [Risks and why]: none, it's a test-only change [String/UUID change made/needed]: none
Attachment #8505282 -
Flags: approval-mozilla-aurora?
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8505282 [details] [diff] [review] scratchpad-tests.patch TIL: no approval required for test-only fixes.
Attachment #8505282 -
Flags: approval-mozilla-aurora?
Reporter | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d222568551bf
status-firefox33:
--- → wontfix
status-firefox34:
--- → wontfix
status-firefox35:
--- → fixed
status-firefox36:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•