Closed
Bug 1083073
Opened 10 years ago
Closed 10 years ago
Strengthens update test about silent update pref
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
2.70 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
In bug 1072181, we are about to turn app.update.silent to true for the dev edition. That ends up breaking various update test that rely on this pref to be false by default.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → poirot.alex
Assignee | ||
Comment 1•10 years ago
|
||
Here is a patch to just ensure this pref is false when we run update tests.
Attachment #8505342 -
Flags: review?(netzen)
Assignee | ||
Comment 2•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=79d182418c32
Comment 3•10 years ago
|
||
Comment on attachment 8505342 [details] [diff] [review] patch Note that this pref was added ages ago for testing purposes. Then people started using it to prevent notifications. There is every chance in the world that there are cases where it does notify. There is also nothing we can do to notify them of an update if it still works and they need to opt-in to an update due to extension compatibility, etc.
Attachment #8505342 -
Flags: review?(netzen) → review+
Comment 4•10 years ago
|
||
You might consider changing the amount of time until the notification to restart is shown instead. You could notify after a week or two instead.
Assignee | ||
Comment 5•10 years ago
|
||
Panos, I think you want to know about the last two comments. app.update.silent may not be the best shot for silent updates... In the meantime, I think we can land this patch that will make the test just more robust.
Flags: needinfo?(past)
Keywords: checkin-needed
Comment 6•10 years ago
|
||
If you want to feel free to schedule some time with me to discuss the options available to you.
Comment 7•10 years ago
|
||
Thanks, I didn't know about any of this. In bug 1080406 I'm trying to use a less intrusive mechanism to notify about updates, and in my testing I haven't actually seen any update notifications on nightly with the pref enabled. Joe, could we schedule a meeting with Rob and anyone else who would be interested?
Flags: needinfo?(past) → needinfo?(jwalker)
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/074a7010a1ad
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/074a7010a1ad
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla36
Comment 10•10 years ago
|
||
Comment on attachment 8505342 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: it's a test improvement that will be required once we uplift some other patches that will make the failure permanent [User impact if declined]: none, only test failures [Describe test coverage new/current, TBPL]: existing test [Risks and why]: none, it's a test-only change [String/UUID change made/needed]: none
Attachment #8505342 -
Flags: approval-mozilla-aurora?
Comment 11•10 years ago
|
||
Comment on attachment 8505342 [details] [diff] [review] patch Test only changes to aurora can land as follows https://wiki.mozilla.org/Tree_Rules "Exception: If patches only make changes to tests, test harnesses or anything else that does not affect the shipped builds, they may land with self approval (use a=testonly, a=npotb etc)."
Attachment #8505342 -
Flags: approval-mozilla-aurora?
Comment 12•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/a1366e157fb1
status-firefox33:
--- → wontfix
status-firefox34:
--- → wontfix
status-firefox35:
--- → fixed
status-firefox36:
--- → fixed
Comment 13•10 years ago
|
||
Thanks for the cluebat Rob!
Updated•9 years ago
|
Flags: qe-verify-
Updated•9 years ago
|
Flags: needinfo?(jwalker)
You need to log in
before you can comment on or make changes to this bug.
Description
•