Closed Bug 1083104 Opened 5 years ago Closed 5 years ago

incorrect line-breaking within embedded spans in vertical writing mode

Categories

(Core :: Layout: Block and Inline, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jfkthame, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

In vertical writing mode, we appear to do line-breaking OK within a simple block, but if there are embedded spans (<b> or <i> elements, etc) within the line, we get totally inappropriate breaks; it looks like the wrong available width must be getting passed to the child elements for line-breaking purposes.

Testcase attached; set the writing mode to vertical-lr and use the slider to vary the size of the <div> within which the text is being displayed.

(In vertical-rl mode, the same line-breaking issues occur, but the display is further confused due to bug 1082844 displaying fragments in the wrong places.)
This one turned out to be a trivial oversight from bug 789096. :)
Attachment #8505410 - Flags: review?(smontagu)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8505410 [details] [diff] [review]
Fix misuse of physical instead of logical dimension for line breaking.

Review of attachment 8505410 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, thank you for catching that.
Attachment #8505410 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/0a7825c642ff
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1079125
No longer blocks: writing-mode
You need to log in before you can comment on or make changes to this bug.