108321 - ~30% of HTMLContentSink::AddAttributes() spent in the component manager.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Johnny Stenback (:jst)]

For every HTML element that has attributes we use the component manager to
create the nsHTMLAttributes object that holds the attributes in stead of just
simply calling NS_NewHTMLAttributes(), duh!

Patch coming up that fixes the performance problems and cleans up
nsHTMLStyleSheet.cpp quite a bit.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Don't use the component manager to create the attributes holder, and clean things up a bit...

Comment 2

[Johnny Stenback (:jst)]

Waterson, dp, reviews?

Comment 3

[David Hyatt]

PRInt32 nameSpace;
styledContent->GetNameSpaceID(nameSpace);
if (kNameSpaceID_HTML == nameSpace) {

Change the above to IsContentOfType.  

sr=hyatt

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 56378 [details] [diff] [review]
Don't use the component manager to create the attributes holder, and clean things up a bit...

r=dbaron

Comment 5

[Johnny Stenback (:jst)]

Fix checked in.