108323 - errors to console about ldap service and ioservice

Status: VERIFIED FIXED

(MailNews Core :: LDAP Integration, defect)

Description

[(not reading, please use [e-mail] instead)]

errors to console about ldap service and ioservice

fallout from your landing, I think.

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'Illegal value' when calling method: [nsIFactory::createInstance]
"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrom
e://messenger/content/messengercompose/MsgComposeCommands.js :: InitializeGlobal
Variables :: line 96"  data: no]
************************************************************
ERROR: Cannot get the LDAP service
[Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETU
RNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RET
URNED_FAILURE)"  location: "JS frame :: chrome://messenger/content/messengercomp
ose/MsgComposeCommands.js :: InitializeGlobalVariables :: line 96"  data: no]
WARNING: waaah!, file c:\builds\bugs\mozilla\content\xul\document\src\nsXULProto
typeDocument.cpp, line 659
JavaScript strict warning:
chrome://editor/content/ComposerCommands.js line 699: redeclaration of var vwin

WEBSHELL+ = 6
JavaScript strict warning:
chrome://messenger/content/messengercompose/MsgComposeCommands.js line 646: refe
rence to undefined property gIOService.offline

JavaScript strict warning:
chrome://messenger/content/messengercompose/MsgComposeCommands.js line 646: refe
rence to undefined property gIOService.offline

JavaScript strict warning:
chrome://messenger/content/messengercompose/MsgComposeCommands.js line 646: refe
rence to undefined property gIOService.offline

JavaScript strict warning:
chrome://messenger/content/messengercompose/MsgComposeCommands.js line 646: refe
rence to undefined property gIOService.offline

JavaScript strict warning:
chrome://messenger/content/messengercompose/MsgComposeCommands.js line 646: refe
rence to undefined property gIOService.offline

Comment 1

[Jean-Francois Ducarroz]

I Have a fix for the LDAP problem however, I cannot reproduce the offline warning!

Comment 2

[Jean-Francois Ducarroz]

Attachment: Proposed fix, v1

Comment 3

[Jean-Francois Ducarroz]

I have no clue why I cannot initialize the ldap service in one line like other
services. This is magic!

Comment 4

[varada]

Comment on attachment 56570 [details] [diff] [review]
Proposed fix, v1

r=varada
I wonder why this works though.

Comment 5

[Jean-Francois Ducarroz]

The code use to be in two lines before i broke it!

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 56570 [details] [diff] [review]
Proposed fix, v1

sr=sspitzer

Comment 7

[Jean-Francois Ducarroz]

Fixed and checked in (the LDAP part). Please reopen if you are able to reproduce
the offline warnings

Comment 8

[jag (Peter Annema)]

I bet the QI is failing. Though in that case you would still be seeing an error
message on the console. Hmmm.

Humor me and try something like:

  try {
      gLDAPPrefsService =
Components.classes["@mozilla.org/ldapprefs-service;1"].getService();
  } catch (ex) {dump ("ERROR: cannot get the LDAP service\n" + e + "\n");}

  try {
      gLDAPPrefsService = gLDAPPrefsService.QueryInterface(
Components.interfaces.nsILDAPPrefsService);
  } catch (ex) {dump ("ERROR: Cannot QI the LDAP service\n" + e + "\n");}

This should tell you which step is going wrong. If both these steps succeed,
something real screwy must be going on. CC'ing some people who might know what's
happening here.

Ugh, I was going to comment about your use of 4-space indent where it was
2-space. And while the largest portion of the file looks to be using 2-space
indent, I'm seeing 1-space and 4-space indents, and the mode line says it should
be 4-space (incorrect mode line?). Someone feel like cleaning that up?

Also, you've put a space after the opening parenthesis on the QI line, which is
out-of-style for this file.

Comment 9

[John Bandhauer]

>  } catch (ex) {dump ("ERROR: cannot get the LDAP service\n" + e + "\n");}
<  } catch (ex) {dump ("ERROR: cannot get the LDAP service\n" + ex + "\n");}

Comment 10

[jag (Peter Annema)]

Erh, yes. In both cases, actually. Thanks for catching that, jband.

Comment 11

[grylchan]

Using commercial
2003-01-02-05-trunk Xp
2003-01-02-08-trunk Mac OS 10.1.2, linux 2.2

verified no error mesgs in this bug appeared in javascript console
when connected to a ldap server and doing some address autocompletion
based off the ldap server.

marking as verified.