profile manager dialog looks bad screen shot coming.
there are a bunch of messed up dialogs. addressbook (card pane is fully horked, directory pane looks weird) msgSelectOffline.xul (outliner is hosed) msgSynchronize.xul (buttons are too tall)
ok, I've fixed abCardViewOverlay.xul blake, you forgot to test.
17 years ago
Severity: normal → critical
Summary: profile manager dialog looks bad → many dialog look bad (select profile, addressbook, select offline, offline sync)
blake, you eeeeeeeeediot I fixed as many as I could spot, I am sure there are some I missed and monday morning's QA run will be a blast.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Yes, if everyone does not know by now, I forgot to commit from mozilla/profile...
Seth, I tested as much UI as I could find in both skins. Addressbook (the only truly blatant UI that you mentioned) is fine for me in my build. I don't consider "outliner is hosed" and "buttons are too tall" such major problems. I knew there would be a couple of UI issues and I have the weekend to iron them out.
Joe: Monday morning's QA run will be fine. Why are things being blown out of proportion? I think, considering the magnitude of the changes made, this went fine. I forgot to checkin in profile changes (I didn't do a top-level commit so bonsai didn't die): done. The Mail team is working on performance and footprint, I don't think too-tall buttons in an offline dialog are getting in anyone's way. I purposely landed on a Friday night so I'd have the weekend to clean up. To top it off, there aren't even builds this weekend. Seth, I appreciate you fixing problems that cropped up, but I would have gladly done it myself today.
the select offline dialog is still hosed. i'll open a new bug for that.
Summary: many dialog look bad (select profile, addressbook, select offline, offline sync) → many dialogs look bad (select profile, addressbook, select offline, offline sync)
Verified. See bug 108564 for select profile dialog problems.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.