Close-paren disables autocorrection of previous word

RESOLVED FIXED

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dholbert, Assigned: anirudhgp, Mentored)

Tracking

unspecified

Firefox Tracking Flags

(b2g-v2.2 fixed)

Details

(Whiteboard: [good first bug][lang=js][mentor-lang=zh])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
(Feel free to replace "Tesy" with any slightly-typo'd word, in my examples below)

STR:
 0. Open Messaging app or any other app with a text field.
 1. Type in your typo'd word.
  ---> IMPORTANT: Make sure there's a blue-highlighted autocorrect suggestion.

 3. Now, type any of the following:
     - a close-paren
     - a double-quote character

So, you've typed in e.g.: 'Tesy)' or 'Tesy"'

EXPECTED RESULTS:
 Typo should be autocorrected when you type in the punctuation.

ACTUAL RESULTS:
 Typo is not autocorrected. I have to go back and fix it myself.


(I get EXPECTED RESULTS if I type in a period, or a comma, a question mark, or an exclamation point, in step 3. But close-paren disables the autocorrection for some reason.)

I'm using a Flame running a FxOS 2.1-based build, from the "aurora" update channel.
(Reporter)

Updated

3 years ago
OS: Linux → All
Hardware: x86_64 → All
This should be a good first bug to add both ) and " symbol as an end symbol to trigger auto-correction.
The code lives in,
 https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/imes/latin/latin.js
Mentor: rlu@mozilla.com
Whiteboard: [good first bug][lang=js][mentor-lang=zh]

Comment 2

3 years ago
I'm interested in working on this bug. I'll try and get Gaia setup.
(Assignee)

Comment 3

3 years ago
So we just have to add ) and " as keywords and  then add these 2 cases in this place: https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/imes/latin/latin.js#L391 ?
(Assignee)

Comment 4

3 years ago
(In reply to Rudy Lu [:rudyl] from comment #1)
> This should be a good first bug to add both ) and " symbol as an end symbol
> to trigger auto-correction.
> The code lives in,
>  https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/imes/latin/
> latin.js

I'll get on it right away as soon as my build finishes. Can you assign this bug to me?
(Reporter)

Comment 5

3 years ago
Sorry that you guys didn't get responses yet -- Rudy might be out of the office or might've missed your comments.  (For future reference, you can use the "Need more information from [...]" dropdown box at the bottom of a bug page [filling in the email of the person you're waiting on], to better get someone's attention.)

I'm going ahead & assigning this to anirudh, since it sounds like he may have gotten further in getting a build set up & also may be more likely to still be interested in working on this (having commented more recently).
Assignee: nobody → anirudh.gp
(Assignee)

Comment 6

3 years ago
(In reply to Daniel Holbert [:dholbert] from comment #5)
> Sorry that you guys didn't get responses yet -- Rudy might be out of the
> office or might've missed your comments.  (For future reference, you can use
> the "Need more information from [...]" dropdown box at the bottom of a bug
> page [filling in the email of the person you're waiting on], to better get
> someone's attention.)
> 
> I'm going ahead & assigning this to anirudh, since it sounds like he may
> have gotten further in getting a build set up & also may be more likely to
> still be interested in working on this (having commented more recently).

Thanks a lot. I'm working on this bug right now.
(Assignee)

Comment 7

3 years ago
What keycodes do i assign to ) and " ? I see that the other punctuation marks have been assigned some numbers.
(Assignee)

Updated

3 years ago
Flags: needinfo?(rlu)
(Assignee)

Updated

3 years ago
Flags: needinfo?(rlu)
(Assignee)

Updated

3 years ago
Flags: needinfo?(rlu)
(Assignee)

Comment 8

3 years ago
Created attachment 8512561 [details] [review]
Pull request for adding ) and " as end symbols to trigger auto-correction in latin.js file
Attachment #8512561 - Flags: review?(rlu)
Comment on attachment 8512561 [details] [review]
Pull request for adding ) and " as end symbols to trigger auto-correction in latin.js file

Looks great! r=me.

Sorry for the delay, I should have noticed the comments earlier.


Daniel,

Thanks for your help as well.
Flags: needinfo?(rlu)
Attachment #8512561 - Flags: review?(rlu) → review+
master,
https://github.com/mozilla-b2g/gaia/commit/fad63415b731cee5ed1a1c8432b1ba0804aaa7c5
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-v2.2: --- → fixed
Resolution: --- → FIXED
(Assignee)

Comment 11

3 years ago
No problem :)
You need to log in before you can comment on or make changes to this bug.