Closed
Bug 1083447
Opened 10 years ago
Closed 10 years ago
texParameter and getTexParameter should accept the TEXTURE_3D target in WebGL2 mode
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: bjacob, Assigned: bjacob)
Details
Attachments
(1 file)
712 bytes,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8505727 -
Flags: review?(jgilbert)
Comment 1•10 years ago
|
||
Comment on attachment 8505727 [details] [diff] [review] accept-texture-3d-target Review of attachment 8505727 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/WebGLContextValidate.cpp @@ +220,5 @@ > case LOCAL_GL_TEXTURE_CUBE_MAP: > return true; > + case LOCAL_GL_TEXTURE_3D: { > + const bool valid = IsWebGL2(); > + if (!valid) { Pulling `valid` (should be `isValid`) out here seems unnecessary.
Attachment #8505727 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 2•10 years ago
|
||
It's used as the return value just below, which justifies having a constant for it. It's a repeated idiom around our validation code.
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/14b69d2ca694
Assignee: nobody → bjacob
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/14b69d2ca694
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•