1083475 - If I uncheck some tabs to not restore them, many of the other tabs in that window are restored as blank "New Tab"

Status: NEW

(Firefox :: Session Restore, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This is a regression within the last few weeks but not the last few days, since I saw it a few days ago.

If I restore a session and uncheck a few tabs to say not to restore those tabs (e.g., a few news articles I had just opened that I don't want to bother reading anymore), I end up with a window that has a huge number of blank "New Tab" tabs at the end of the window instead of the tabs it should have, although the tabs at the start of the window restore correctly.

In particular, my session currently has slightly over 400 tabs in its "main window", and 3 other windows with 2-10 tabs each.  I just tried to restore the session following a crash, but unchecking the last 3 tabs in the "main window".  When that window restored, the left edge of the tab strip was fine, but switching to the right edge of the tab strip showed the entire tab strip full of tabs called "New Tab" that were blank.

If I restore my (frequently backed up) sessionstore file, I can reproduce the problem if I keep unchecking the three windows, but if I don't uncheck the windows, everything restores successfully.

I'm running my own debug build of Firefox from mozilla-central as of a few hours ago (post RyanVMs) merge, with my own patch queue, on 64-bit Linux.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I've now started seeing this without unchecking some tabs, and in the browser console I see:

Error: Script terminated by timeout at:
get_selectedBrowser@chrome://browser/content/tabbrowser.xml:2626:1
restoreTab@resource:///modules/sessionstore/SessionStore.jsm:2663:1
restoreTabs@resource:///modules/sessionstore/SessionStore.jsm:2550:7
ssi_restoreWindow@resource:///modules/sessionstore/SessionStore.jsm:2483:1
ssi_onLoad@resource:///modules/sessionstore/SessionStore.jsm:865:7
SessionStoreInternal.onBeforeBrowserWindowShown@resource:///modules/sessionstore/SessionStore.jsm:974:7
ssi_observe@resource:///modules/sessionstore/SessionStore.jsm:569:9
gBrowserInit.onLoad@chrome://browser/content/browser.js:10399:5
onload@chrome://browser/content/browser.xul:1:1

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

I think I've never seen "Script terminated by timeout..." messages so far. Did you see a slow script dialog popping up? I would think we don't just kill chrome scripts, do we?

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

No slow script dialog.  It sure looks like we just kill them.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

The termination message was implemented by bug 968936, so seems like there should have been a slow script dialog?

Comment 5

[Jason Merrill]

I see something similar when using the UnloadTab extension with Nightly (2015-07-15): when I restart, any unloaded tabs to the right of the one I was looking at become "New Tab" and empty when I switch to them.

The UnloadTab extension is somewhat broken in 41 and up due to bug 874381 changes, so I think I'm going to stop using it, but since I only see the "New Tab" issue with Nightly (42), not Dev (41) this might be useful for reproducing the more general issue.

Comment 6

[Wayne Mery (:wsmwk)]

Jason, do you still see this problem?

(In reply to Jason Merrill from comment #5)
> I see something similar when using the UnloadTab extension with Nightly
> (2015-07-15): when I restart, any unloaded tabs to the right of the one I
> was looking at become "New Tab" and empty when I switch to them.
> 
> The UnloadTab extension is somewhat broken in 41 and up due to bug 874381
> changes, so I think I'm going to stop using it, but since I only see the
> "New Tab" issue with Nightly (42), not Dev (41) this might be useful for
> reproducing the more general issue.

I think the only SS code that changed in the time period you cite is bug 1166757 (as best as I can tell from BMO - I didn't check hg.

Comment 7

[Wayne Mery (:wsmwk)]

dbaron,
Do you still see this problem?

FWIW, I've seen blank new tabs restored in recent months, but never as a result of unchecking a tab to be restored

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I haven't seen this for quite a while, but:
 * I haven't unchecked tabs for quite a while
 * I changed dom.max_chrome_script_run_time to 60 (default is 20)

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.