Do something about duplicate languages in language selection

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: errietta, Unassigned)

Tracking

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
When creating an event, language has duplicates like "English (English)" "English (US)" or even "English (Upside Down)", we probably don't need all of these options and it can be confusing
(Reporter)

Comment 1

4 years ago
[23:11] < gvn> 3:09 PM <aali> probably the best way to do this would be grab all `xx` locale
[23:11] < gvn> 3:09 PM <aali> and find any locale `xx-XX` that does not have `xx` as its base locale
(Reporter)

Comment 2

4 years ago
Created attachment 8506403 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/216

https://github.com/alicoding/language-mapping-list/blob/master/language-mapping-list.js#L157 why is this in a different format from everything else?
Flags: needinfo?(ali)
Attachment #8506403 - Flags: review?(gavin)
That's just the locale standard for en@pirate :)
I don't think we want to remove that :)

Comment 6

4 years ago
Comment on attachment 8506403 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/216

Just a few things noted on GH, but much better!
Attachment #8506403 - Flags: review?(gavin) → review-

Comment 7

4 years ago
I really think we should remove Pirate for Events. It makes absolutely no sense for an event to be conducted in "Pirate English".
Remove in the event but not in the lang list trio I think
(Reporter)

Updated

4 years ago
Attachment #8506403 - Flags: review- → review?(gavin)
s/trio/repo

Failed autocorrect >.<
Comment on attachment 8506451 [details] [review]
https://github.com/alicoding/language-mapping-list/pull/2

This repo is mainly use by every one and I'm trying to keep it as a standard for all known locale, and en@pirate is one of them. So, to make sure this is not in the event I think the right thing here is to filter them out in the event specifically and not directly in the repo.
Attachment #8506451 - Flags: review?(ali) → review-
(Reporter)

Updated

4 years ago
Attachment #8506403 - Flags: review- → review?(gavin)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.