1083536 - Remove max-width & max-height from input[type=checkbox] in content.css

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Mike Taylor [:miketaylr]]

This bug is for the Firefox OS half of Bug #1082757.

+++ This bug was initially created as a clone of Bug #1082757 +++

Originally reported in Bug 1078393, the current max-width: 14px style prevents Fennec users from being able to interact with "custom" checkbox styling techniques [1].

I wrote about this in https://miketaylr.com/posts/2014/10/max-width-in-firefox-mobile-browser-checkboxes.html. 

Compare Mobile Safari, Chrome Mobile, Opera Mobile, and Windows Phone with Fennec (or Firefox OS, to be filed) on the linked demo [2].

Note that desktop doesn't have max-width on it's checkboxes so people who don't test on mobile won't even know they need to manually override the ua stylesheet's max-width.

The patch is simple... my only concern is there might be some internal code relying on the max-width of a checkbox being exactly 14px. 

[1] http://tympanus.net/codrops/2012/09/13/button-switches-with-checkboxes-and-css3-fanciness/
[2] https://miketaylr.com/bzla/1078393-1.html

Comment 1

[Mike Taylor [:miketaylr]]

Attachment: 1083536.patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8505831 [details] [diff] [review]
1083536.patch

Gotta love copy/paste...

There's no code in layout that would depend on this.  I can't speak to the native theming code.

Comment 3

[Mike Taylor [:miketaylr]]

Attachment: 1083536-2.patch

Added r=bz to commit message.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9cdce80d5092

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9cdce80d5092