Closed Bug 1083536 Opened 5 years ago Closed 5 years ago

Remove max-width & max-height from input[type=checkbox] in content.css

Categories

(Core :: Layout: Form Controls, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: miketaylr, Assigned: miketaylr)

References

()

Details

Attachments

(1 file, 1 obsolete file)

This bug is for the Firefox OS half of Bug #1082757.

+++ This bug was initially created as a clone of Bug #1082757 +++

Originally reported in Bug 1078393, the current max-width: 14px style prevents Fennec users from being able to interact with "custom" checkbox styling techniques [1].

I wrote about this in https://miketaylr.com/posts/2014/10/max-width-in-firefox-mobile-browser-checkboxes.html. 

Compare Mobile Safari, Chrome Mobile, Opera Mobile, and Windows Phone with Fennec (or Firefox OS, to be filed) on the linked demo [2].

Note that desktop doesn't have max-width on it's checkboxes so people who don't test on mobile won't even know they need to manually override the ua stylesheet's max-width.

The patch is simple... my only concern is there might be some internal code relying on the max-width of a checkbox being exactly 14px. 

[1] http://tympanus.net/codrops/2012/09/13/button-switches-with-checkboxes-and-css3-fanciness/
[2] https://miketaylr.com/bzla/1078393-1.html
No longer depends on: 1082757
See Also: → 1082757
Attached patch 1083536.patch (obsolete) — Splinter Review
Assignee: nobody → miket
Comment on attachment 8505831 [details] [diff] [review]
1083536.patch

Gotta love copy/paste...

There's no code in layout that would depend on this.  I can't speak to the native theming code.
Attachment #8505831 - Flags: review?(bzbarsky) → review+
Attached patch 1083536-2.patchSplinter Review
Added r=bz to commit message.
Attachment #8505831 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/9cdce80d5092
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.