Closed Bug 1083571 Opened 8 years ago Closed 8 years ago

Perma-failing gaia tests after last m-c to b2g-inbound merge

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S7 (24Oct)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file, 4 obsolete files)

M-c errors appear to trackback to an inbound merge here: https://tbpl.mozilla.org/?showall=1&rev=a280a03c9f3c
Flags: needinfo?(bobbyholley)
Note that Gij is currently hidden which is unfortunate, and we are working on getting this suite un-hidden asap.
It looks like running the test is causing this message to get logged:

[marionette error] app://sms.gaiamobile.org/js/message_manager.js:22 Error: Exposing privileged or cross-origin callable is prohibited

That links to this file, but if that's a line number it seems bogus: https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/message_manager.js
The error is generally preceded by:   [marionette error] chrome://global/content/BrowserElementChildPreload.js:79 TypeError: content.document.body is null
mock_navigator_moz_mobile_message.js is definitely handing out chrome functions to content, after doing the exposeObject() thing.  That's no longer good enough; the functions should be cloned into the content compartment.

mock_navigator_moz_icc_manager.js is OK for now, but should be fixed for bug 1065186 because it will break once that lands, I bet.  Again, you want to clone the object you're returning to content into the content compartment.
Blocks: 1083636
Here is a WIP, unfortunately I need to run soon and won't be able to finish this tonight. Anyone is free to steal this from me.
Evan, any update on finishing off Kevin's patch?
Assignee: nobody → evanxd
Flags: needinfo?(evanxd)
For the SMS tests, we might need SMS people here to figure out the issue.
Flags: needinfo?(schung)
This commit[1] is for mozIccManager and mozMobileMessage mocks, and we could check it in the PR[2].

[1] https://github.com/evanxd/gaia/commit/7f282498c9fc0cbfd9c3d1d43f94574c67904fa4
[2] https://bugzilla.mozilla.org/attachment.cgi?id=8506076
And thanks for bholley's help.
Assignee: evanxd → nobody
Got to go. Anyone feels free to steal this.
I wrote mockups (untested) for all of the __exposedProps__ removals for gaia mock objects. Presumably Evan's patches are based on these, but here they are for posterity. They may have syntax errors etc, but conceptually they should do the trick:

https://github.com/bholley/gaia/commits/remove_exposedprops_from_mocks
Flags: needinfo?(bobbyholley)
Attached file Patch from Bholley (obsolete) —
Attachment #8505954 - Attachment is obsolete: true
After chatting to Bholley on IRC for a bit I think I have somewhat of an idea of how to fix the remaining tests.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Attached file Pull request - Remove __exposedProps__ (obsolete) —
Attachment #8506076 - Attachment is obsolete: true
Attachment #8506125 - Attachment is obsolete: true
Comment on attachment 8506250 [details] [review]
Pull request - Remove __exposedProps__

Here is the current try run: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=a7ce63918374

I'm going to squash the commits now. Mike - could you give this a quick look, and if we get a passing Gij run here we can re-open the trees.
Attachment #8506250 - Flags: review?(mhenretty)
Comment on attachment 8506250 [details] [review]
Pull request - Remove __exposedProps__

Left a comment on github. But even fixing that, we are still getting errors in share_activity_test.js. It looks like it has something to do with the keyboard. I'm investigating it now.
Comment on attachment 8506250 [details] [review]
Pull request - Remove __exposedProps__

NM, fixing the sms message mock fixes share_activity_test.js. I'm going to submit a new PR with that fix and if it passes on treeherder, I'll land.
Attachment #8506250 - Flags: review?(mhenretty) → review+
r+ carries from my previous review. watching treeherder now:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=b965b625072e
Attachment #8506250 - Attachment is obsolete: true
Attachment #8506391 - Flags: review+
\o/ we have a green build. Landing.

https://github.com/mozilla-b2g/gaia/commit/3184634389eb4b2858ad8cf3125a09242b4a7d05
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(schung)
Resolution: --- → FIXED
Hi Kevin,

For skipping this kind of issue happen again, how about we run Gij job for gecko patch? Or do you know why we don't do this currently?

Thanks.
Flags: needinfo?(kgrandon)
(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #27)
> Hi Kevin,
> 
> For skipping this kind of issue happen again, how about we run Gij job for
> gecko patch? Or do you know why we don't do this currently?
> 
> Thanks.

Sure, getting Gij visible on TBPL is top priority and we're currently tracking this in bug 960072. The main problem we're facing right now is the harness issues tracked in bug 1037924. James Lal is doing some work there to address these.
Flags: needinfo?(kgrandon)
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S7 (24Oct)
See Also: → 960072
Can you send a mail about this on dev-gaia?
(In reply to Julien Wajsberg [:julienw] from comment #29)
> Can you send a mail about this on dev-gaia?

Yup, great idea. I'll do so now.
You need to log in before you can comment on or make changes to this bug.