1083592 - Make device type code more DRY in `compatibility_filtering.js`

Status: VERIFIED FIXED

(Marketplace Graveyard :: Code Quality, defect, P5)

Description

[Christopher Van Wiemeersch [:cvan]]

Bug 969244 added device filtering.

I could be misunderstanding things, but it seems that https://github.com/mozilla/fireplace/blob/3157104/src/media/js/compatibility_filtering.js#L17-L38 duplicates a bunch of logic that's already written in `capabilities.js`:

https://github.com/mozilla/fireplace/blob/master/src/media/js/commonplace/capabilities.js#L53-L64

Comment 1

[Mathieu Pillard [:mat]]

I totally missed the code in capabilities.js when I wrote compatibility_filtering.js. It's fairly similar yes, except that the one in compatibility_filtering.js does not set the device name to 'desktop' by default, in order not to filter on desktop by default.

Comment 2

[Mathieu Pillard [:mat]]

https://github.com/mozilla/marketplace-core-modules/commit/ed17eda724dd4edec8ccb9862a39eb78d6481f9d refactors the device_* methods (and introduces new ones) in capabilities.js to help with that. Now I need to use the new methods in fireplace's compatibility_filtering.js (preserving the "desktop" exception)

Comment 3

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/fireplace/commit/e512af12b4a658dba63ca73ebe8ff3fb97adfd0a

QA:
- Please make sure the compatibility filtering dropdown in search results, category page and new/popular pages is still working properly

Comment 4

[Victor Carciu]

Verified as fixed for all places where we have device filtering.