Closed
Bug 1083597
Opened 10 years ago
Closed 10 years ago
Port the code calling nsRenderingContext::DrawRect() to Moz2D
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
13.42 KB,
patch
|
mattwoodrow
:
review+
jwatt
:
checkin+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8505894 -
Flags: review?(matt.woodrow)
Updated•10 years ago
|
Attachment #8505894 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8505894 [details] [diff] [review] patch https://hg.mozilla.org/integration/mozilla-inbound/rev/4714ac6ccbfe
Attachment #8505894 -
Flags: checkin+
Assignee | ||
Comment 3•10 years ago
|
||
I noticed that this change lost us some pixel snapping. nsRenderingContext::DrawRect passed true as the 'snapToPixels' argument when calling gfxContext::Rectangle, but the new NSRectToRect function does not do that. I'll land a follow-up shortly. I'll actually only fix the nsTableCellFrame::DecorateForSelection case though, since all the other touched rect drawing code is DEBUG code.
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2dbb3fbd7385
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4714ac6ccbfe https://hg.mozilla.org/mozilla-central/rev/2dbb3fbd7385
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•