Closed Bug 1083597 Opened 10 years ago Closed 10 years ago

Port the code calling nsRenderingContext::DrawRect() to Moz2D

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

      No description provided.
Attached patch patchSplinter Review
Attachment #8505894 - Flags: review?(matt.woodrow)
Attachment #8505894 - Flags: review?(matt.woodrow) → review+
I noticed that this change lost us some pixel snapping. nsRenderingContext::DrawRect passed true as the 'snapToPixels' argument when calling gfxContext::Rectangle, but the new NSRectToRect function does not do that. I'll land a follow-up shortly. I'll actually only fix the nsTableCellFrame::DecorateForSelection case though, since all the other touched rect drawing code is DEBUG code.
https://hg.mozilla.org/mozilla-central/rev/4714ac6ccbfe
https://hg.mozilla.org/mozilla-central/rev/2dbb3fbd7385
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Blocks: 1087958
You need to log in before you can comment on or make changes to this bug.