1083613 - Use CSS instead of JS to toggle visibility of category drop-down on desktop

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/blob/8ebaa03/src/media/js/navbar.js#L225-L236

Instead of adding all those event listeners, we could instead just do this:

    .categories:hover .hovercats { display: block }

It looks like the JS was added in https://github.com/mozilla/fireplace/commit/90619b84 but I couldn't determine a good reason why JS was used instead of CSS. Maybe there is.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

PR: https://github.com/mozilla/fireplace/pull/727

Comment 2

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/fccc451

QA: Please make sure that the category drop-down on desktop works just like it currently does on prod. Please also make sure that the mobile Categories nav item and page work as they do on prod. Thanks!

Comment 3

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/ on FF36 (Win 7, Android 4.2.1) and FF OS 1.4 (Inari).
Closing bug.