Use CSS instead of JS to toggle visibility of category drop-down on desktop

VERIFIED FIXED in 2014-11-04

Status

VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: cvan, Assigned: cvan)

Tracking

2014-11-04
Points:
---

Details

(Whiteboard: [qa+], URL)

https://github.com/mozilla/fireplace/blob/8ebaa03/src/media/js/navbar.js#L225-L236

Instead of adding all those event listeners, we could instead just do this:

    .categories:hover .hovercats { display: block }

It looks like the JS was added in https://github.com/mozilla/fireplace/commit/90619b84 but I couldn't determine a good reason why JS was used instead of CSS. Maybe there is.
https://github.com/mozilla/fireplace/commit/fccc451

QA: Please make sure that the category drop-down on desktop works just like it currently does on prod. Please also make sure that the mobile Categories nav item and page work as they do on prod. Thanks!
Assignee: nobody → cvan
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [qa+]
Target Milestone: --- → 2014-11-04

Comment 3

4 years ago
Verified as fixed in https://marketplace-dev.allizom.org/ on FF36 (Win 7, Android 4.2.1) and FF OS 1.4 (Inari).
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.