Closed
Bug 1083653
Opened 8 years ago
Closed 8 years ago
Intermittent marStageSuccessPartialSvc.js | test failed (with xpcshell return code: 0), see following log:
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
People
(Reporter: cbook, Assigned: robert.strong.bugs)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
737 bytes,
patch
|
spohl
:
review+
|
Details | Diff | Splinter Review |
Windows XP 32-bit fx-team debug test xpcshell https://treeherder.mozilla.org/ui/logviewer.html#?job_id=916656&repo=fx-team 19:08:03 WARNING - TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\tests\unit_service_updater\marStageSuccessPartialSvc.js | test failed (with xpcshell return code: 0), see following log:
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
![]() |
Assignee | |
Comment 22•8 years ago
|
||
An example (first 3 lines are not checked by the tests since they have paths) from a complete update on my system. I am very certain that the following call to LOG is the cause http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/updater/updater.cpp#2060 PATCH DIRECTORY <path to updates dir?\updates\0 INSTALLATION DIRECTORY <path to install dir>\Mozilla Firefox Beta WORKING DIRECTORY <path to install dir>\Mozilla Firefox Beta calling QuitProgressUI EPARE REMOVEFILE xul.dll PREPARE REMOVEFILE wow_helper.exe etc... succeeded calling QuitProgressUI Instead of trying to rework the logging I am just going to remove this one call to LOG.
![]() |
Assignee | |
Comment 23•8 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=52d02c0fbb43
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
![]() |
Assignee | |
Updated•8 years ago
|
![]() |
Assignee | |
Updated•8 years ago
|
Attachment #8588269 -
Flags: review?(spohl.mozilla.bugs)
Comment 25•8 years ago
|
||
Comment on attachment 8588269 [details] [diff] [review] patch rev1 Review of attachment 8588269 [details] [diff] [review]: ----------------------------------------------------------------- Happy to try this. Do you know why a call to LOG would cause this?
Attachment #8588269 -
Flags: review?(spohl.mozilla.bugs) → review+
![]() |
Assignee | |
Comment 26•8 years ago
|
||
There are 2 processes... one that is unelevated that starts the service and another that is launched elevated by the service. This is the unelevated one writing to the log file.
Comment 27•8 years ago
|
||
Makes sense, thanks!
![]() |
Assignee | |
Comment 28•8 years ago
|
||
Pushed to fx-team https://hg.mozilla.org/integration/fx-team/rev/51bdbe58fc2d
Flags: in-testsuite+
Target Milestone: --- → mozilla40
Updated•8 years ago
|
status-b2g-v2.2:
--- → affected
status-b2g-master:
--- → fixed
status-firefox37:
--- → wontfix
status-firefox38:
--- → affected
status-firefox39:
--- → affected
status-firefox-esr31:
--- → unaffected
Comment hidden (Legacy TBPL/Treeherder Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•