1083671 - Give clobberer an explicit timezone

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[Morgan Phillips [:mrrrgn]]

Clobberer currently uses the system's default timezone on client and server. This could lead to scenarios where clobbers break. The current system should have explicit timezones. Preferably PDT, since that's what everything has been operating up until this point.

*note* verification of PDT as the current clobberer timezone =>

[[e-mail]3 ~]$ date
Thu Oct 16 00:35:47 PDT 2014

Comment 1

[Morgan Phillips [:mrrrgn]]

Attachment: Explicit Timezone For Current Clobberer

Even though this is a small change, it needs testing on all platforms because it touches the client. This could break clobbers. The only way to test atm is manually, so I'm just throwing this patch out for now and will come back to it with varifications on each platform as I'm able. Let me know if this approach seems lame.

Comment 2

[Morgan Phillips [:mrrrgn]]

Attachment: Explicit Timezone For Current Clobberer (Always Clobber)

Nearly forgot always_clobber.php

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 8506009 [details] [diff] [review]
Explicit Timezone For Current Clobberer

Review of attachment 8506009 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine to me. Yay pytz :)

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8506009 [details] [diff] [review]
Explicit Timezone For Current Clobberer

Review of attachment 8506009 [details] [diff] [review]:
-----------------------------------------------------------------

my only concern with this, is if pytz is not available in the context the existing clobberer runs in

Comment 5

[Morgan Phillips [:mrrrgn]]

dustin brought up a good point on here which makes me believe this isn't a top priority for now. Clobberer can still move forward so long as we keep using UNIX epoch time (time.time()) I'll need to investigate if having a TZ environment variable set effects this. If it does, I'll just unset it within the script.

Comment 6

[Morgan Phillips [:mrrrgn]]

Above, beside "on here," I meant to add this link => https://github.com/mozilla/build-relengapi-clobberer/pull/3#issuecomment-59360424