Give clobberer an explicit timezone

RESOLVED WONTFIX

Status

Release Engineering
General
RESOLVED WONTFIX
4 years ago
a year ago

People

(Reporter: mrrrgn, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Clobberer currently uses the system's default timezone on client and server. This could lead to scenarios where clobbers break. The current system should have explicit timezones. Preferably PDT, since that's what everything has been operating up until this point.

*note* verification of PDT as the current clobberer timezone =>

[mphillips@relengwebadm.private.scl3 ~]$ date
Thu Oct 16 00:35:47 PDT 2014
(Reporter)

Comment 1

4 years ago
Created attachment 8506009 [details] [diff] [review]
Explicit Timezone For Current Clobberer

Even though this is a small change, it needs testing on all platforms because it touches the client. This could break clobbers. The only way to test atm is manually, so I'm just throwing this patch out for now and will come back to it with varifications on each platform as I'm able. Let me know if this approach seems lame.
Attachment #8506009 - Flags: feedback?(bugspam.Callek)
Attachment #8506009 - Flags: feedback?(bhearsum)
(Reporter)

Comment 2

4 years ago
Created attachment 8506012 [details] [diff] [review]
Explicit Timezone For Current Clobberer (Always Clobber)

Nearly forgot always_clobber.php
Comment on attachment 8506009 [details] [diff] [review]
Explicit Timezone For Current Clobberer

Review of attachment 8506009 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine to me. Yay pytz :)
Attachment #8506009 - Flags: feedback?(bhearsum) → feedback+
Comment on attachment 8506009 [details] [diff] [review]
Explicit Timezone For Current Clobberer

Review of attachment 8506009 [details] [diff] [review]:
-----------------------------------------------------------------

my only concern with this, is if pytz is not available in the context the existing clobberer runs in
Attachment #8506009 - Flags: feedback?(bugspam.Callek) → feedback+

Updated

4 years ago
Attachment #8506012 - Flags: feedback+
(Reporter)

Comment 5

4 years ago
dustin brought up a good point on here which makes me believe this isn't a top priority for now. Clobberer can still move forward so long as we keep using UNIX epoch time (time.time()) I'll need to investigate if having a TZ environment variable set effects this. If it does, I'll just unset it within the script.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
(Reporter)

Comment 6

4 years ago
Above, beside "on here," I meant to add this link => https://github.com/mozilla/build-relengapi-clobberer/pull/3#issuecomment-59360424
(Assignee)

Updated

a year ago
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.