Closed
Bug 1083713
Opened 11 years ago
Closed 11 years ago
[Settings] Re-enable one test case of slider handler
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arthurcc, Assigned: arthurcc)
Details
Attachments
(1 file)
The test case[1] should not be disabled.
[1]: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/test/unit/panels/sound/slider_handler_test.js#L130
|
Assignee | |
Comment 1•11 years ago
|
||
EJ, would you mind check this simple patch? Thanks.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8506036 [details]
link to https://github.com/mozilla-b2g/gaia/pull/25214
Forgot to set the flag. :p
Attachment #8506036 -
Flags: review?(ejchen)
|
||
Comment 3•11 years ago
|
||
It's disabled because it's mysterious not passed ui test in treeherder.
The result still the same.
|
|
Assignee | |
Comment 4•11 years ago
|
||
The mozAudioChannelType of a player on B2G desktop seems not behave as expected. Turned to use a mock object in this patch.
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8506036 [details]
link to https://github.com/mozilla-b2g/gaia/pull/25214
test looks okay, r+
Attachment #8506036 -
Flags: review?(ejchen) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Thanks!
master: fa3e134de208f0f19ff397456ba05735a46149b2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•