1083750 - [Loop] User ISN'T notified that trying to make a Loop Call and lost connectivity

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Loli (:lolimartinezcr)]

Attachment: 2014-10-16-14-24-23.png

STR
1. Make a Loop call from device A to device B
2. While is making call, Wifi connectivity is disabled.

ACTUAL RESULT:
Device A ends the call *without* feedback. On Device B, the invalid feedback window is shown. See image attached

EXPECTED RESULT:
Device A ends the call *with* feedback. On Device B, the feedback window is shown. See image attached


EXPECTED RESULT
As discussed with UX, the feedback window should be closed and the the new call should be shown to the user

Comment 1

[Loli (:lolimartinezcr)]

(In reply to Loli (:lolimartinezcr) from comment #0)
> Created attachment 8506094 [details]
> 2014-10-16-14-24-23.png
> 
> STR
> 1. Make a Loop call from device A to device B
> 2. While is making call, Wifi connectivity is disabled.
> 
> ACTUAL RESULT:
> Device A ends the call *without* feedback. On Device B, the invalid feedback
> window is shown. See image attached
> 
> EXPECTED RESULT:
> Device A ends the call *with* feedback. On Device B, the feedback window is
> shown. See image attached
> 
>

Comment 2

[Loli (:lolimartinezcr)]

Bug created in:

fireE (firee-kk-v2.0-SW2E3-1)
Loop version: 1.1 , 2168965

Comment 3

[Maria Angeles Oteo (:oteo)]

Loli, one question, when you have detected this bug and seen the attached screenshot, the call between A and B was not established yet?

Be aware that feedback screen should only be shown when the call has already been established.

Comment 4

[Loli (:lolimartinezcr)]

(In reply to Maria Angeles Oteo (:oteo) from comment #3)
> Loli, one question, when you have detected this bug and seen the attached
> screenshot, the call between A and B was not established yet?
> 
> Be aware that feedback screen should only be shown when the call has already
> been established.

Hi,

In this bug the call between A and B was not established.

The  mainly problem is attached image, it isn't reporting the real situation in device B. The posible solution is show other information or not appear this screen, but you decide about it.

Comment 5

[Maria Angeles Oteo (:oteo)]

> In this bug the call between A and B was not established.
> 
> The  mainly problem is attached image, it isn't reporting the real situation
> in device B. The posible solution is show other information or not appear
> this screen, but you decide about it.

Thanks Loli, I agree with you.

What we have agreed in the triage is that the screenshot attached should not be shown to the user and that's the reason we have blocked on it.

Not sure about if we could provide more info about the network failed (be aware that it's still pending the patch that Tokbox should provide, see bug 1067946) because the call has not been established yet. Setting ni to Jose Antonio to confirm it.

Regarding the feedback window just to comment that it should no be shown to the users as the call has not been established yet.

Comment 6

[Maria Angeles Oteo (:oteo)]

Loli, I am no to able to see that screenshot and reproduce the issue, could you please retest it when you you have time? Thanks in advance

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

I'm not able to reproduce the screen you see Loli. We give some feedback to the user, either 'Call ended by connection failure' or 'Oops! That didn’t work as expected. Why don’t we give it another try?'. I tried and this is what I see.

Comment 8

[Carmen Jimenez Cabezas]

I've tried to reproduce this bug, but I've always gotten the same result:

Case 1: both devices connected in the same network
- on phone A the message "Call endend by network disconnection" is shown
- on phone B the incomming call is closed

Case 2: devices connected to different networks, and turning off A's router
- on phone A the message "Call endend by network disconnection"
- on phone B: the incomming call will keep ringing for a while after the router is turned off.
    If B doesn't pick up then the incomming call will be closed after a while
    If B picks up then it will show the message "connecting" and after a little time time the call will be ended

The only wrong behavior is the last one I described (case 2) but it doesn't seem to be the same case you were describing.

Can you tell me more details for reproducing this issue?

Comment 9

[Carmen Jimenez Cabezas]

Sorry! I forgot to specify this: 
-  Phone A makes a call to phone B
-  The router is turned off before B picks up

Comment 10

[Loli (:lolimartinezcr)]

(In reply to Maria Angeles Oteo (:oteo) from comment #6)
> Loli, I am no to able to see that screenshot and reproduce the issue, could
> you please retest it when you you have time? Thanks in advance

Retest today again, I am no to able to see that screenshot. 

Scenario 1 (devices in same network): 
-Both devices connected in the same network,
-Device A makes a call to Device B
-Wifi is turned off before B picks up the call

Actual Result:
- on phone A, call is closed without any feed back message.
- on phone B is calling all time.


Scenario 2 (devices in different network, network in device A is turned off):
-Device A connected to Wifi A
-Device B connected to Wifi B 
-Device A makes a call to Device B
-Wifi A is turned off before B picks up the call

Actual result:
- on phone A, call is closed without any feed back message.
- on phone B is calling all time.


Scenario 3 (devices in different network, network in device B is turned off):
-Device A connected to Wifi A
-Device B connected to Wifi B 
-Device A makes a call to Device B
-Wifi B is turned off before B picks up the call

Actual result:
- on phone A, call is closed without any feed back message.
- on phone B is calling all time.