1083753 - Port the code that uses the nsRenderingContext::FillRect methods to Moz2d

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: part 1 - Port the code that uses nsRenderingContext::FillRect(nscoord,...) to Moz2D

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: part 2 - Port the code that uses nsRenderingContext::FillRect(nsRect) to Moz2D

Comment 3

[Jonathan Watt [:jwatt]]

I filed bug 1083755 for the question of whether or not we should port the CAIRO_COORD_MAX etc. code I'm removing from nsRenderingContext.cpp to DrawTargetCairo.

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8506564 [details] [diff] [review]
part 2 - Port the code that uses nsRenderingContext::FillRect(nsRect) to Moz2D

Review of attachment 8506564 [details] [diff] [review]:
-----------------------------------------------------------------

We have plenty of code that doesn't go through nsRenderingContext that isn't having issues, so I'm not sure if we need the ConditionRect code at all.

If this passes tests then I wouldn't be in a rush to port it to DrawTargetCairo.

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 8506099 [details] [diff] [review]
part 1 - Port the code that uses nsRenderingContext::FillRect(nscoord,...) to Moz2D

https://hg.mozilla.org/integration/mozilla-inbound/rev/045556326c7c

Comment 6

[Jonathan Watt [:jwatt]]

Comment on attachment 8506564 [details] [diff] [review]
part 2 - Port the code that uses nsRenderingContext::FillRect(nsRect) to Moz2D

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb4b5b08374

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/045556326c7c
https://hg.mozilla.org/mozilla-central/rev/2cb4b5b08374