Closed
Bug 1083753
Opened 10 years ago
Closed 10 years ago
Port the code that uses the nsRenderingContext::FillRect methods to Moz2d
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(2 files)
17.13 KB,
patch
|
mattwoodrow
:
review+
jwatt
:
checkin+
|
Details | Diff | Splinter Review |
26.52 KB,
patch
|
mattwoodrow
:
review+
jwatt
:
checkin+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8506099 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8506564 -
Flags: review?(matt.woodrow)
Assignee | ||
Updated•10 years ago
|
Attachment #8506564 -
Attachment description: patch → part 2 - Port the code that uses nsRenderingContext::FillRect(nsRect) to Moz2D
Assignee | ||
Comment 3•10 years ago
|
||
I filed bug 1083755 for the question of whether or not we should port the CAIRO_COORD_MAX etc. code I'm removing from nsRenderingContext.cpp to DrawTargetCairo.
Updated•10 years ago
|
Attachment #8506099 -
Flags: review?(matt.woodrow) → review+
Comment 4•10 years ago
|
||
Comment on attachment 8506564 [details] [diff] [review] part 2 - Port the code that uses nsRenderingContext::FillRect(nsRect) to Moz2D Review of attachment 8506564 [details] [diff] [review]: ----------------------------------------------------------------- We have plenty of code that doesn't go through nsRenderingContext that isn't having issues, so I'm not sure if we need the ConditionRect code at all. If this passes tests then I wouldn't be in a rush to port it to DrawTargetCairo.
Attachment #8506564 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8506099 [details] [diff] [review] part 1 - Port the code that uses nsRenderingContext::FillRect(nscoord,...) to Moz2D https://hg.mozilla.org/integration/mozilla-inbound/rev/045556326c7c
Attachment #8506099 -
Flags: checkin+
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8506564 [details] [diff] [review] part 2 - Port the code that uses nsRenderingContext::FillRect(nsRect) to Moz2D https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb4b5b08374
Attachment #8506564 -
Flags: checkin+
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/045556326c7c https://hg.mozilla.org/mozilla-central/rev/2cb4b5b08374
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•