Closed Bug 1083753 Opened 5 years ago Closed 5 years ago

Port the code that uses the nsRenderingContext::FillRect methods to Moz2d

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(2 files)

No description provided.
Attachment #8506564 - Attachment description: patch → part 2 - Port the code that uses nsRenderingContext::FillRect(nsRect) to Moz2D
I filed bug 1083755 for the question of whether or not we should port the CAIRO_COORD_MAX etc. code I'm removing from nsRenderingContext.cpp to DrawTargetCairo.
Attachment #8506099 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8506564 [details] [diff] [review]
part 2 - Port the code that uses nsRenderingContext::FillRect(nsRect) to Moz2D

Review of attachment 8506564 [details] [diff] [review]:
-----------------------------------------------------------------

We have plenty of code that doesn't go through nsRenderingContext that isn't having issues, so I'm not sure if we need the ConditionRect code at all.

If this passes tests then I wouldn't be in a rush to port it to DrawTargetCairo.
Attachment #8506564 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8506099 [details] [diff] [review]
part 1 - Port the code that uses nsRenderingContext::FillRect(nscoord,...) to Moz2D

https://hg.mozilla.org/integration/mozilla-inbound/rev/045556326c7c
Attachment #8506099 - Flags: checkin+
Comment on attachment 8506564 [details] [diff] [review]
part 2 - Port the code that uses nsRenderingContext::FillRect(nsRect) to Moz2D

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb4b5b08374
Attachment #8506564 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/045556326c7c
https://hg.mozilla.org/mozilla-central/rev/2cb4b5b08374
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Blocks: 1087958
Depends on: 1090947
Depends on: 1101571
You need to log in before you can comment on or make changes to this bug.